Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 7491041: remove dead code in fast double elements (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: make Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2214 matching lines...) Expand 10 before | Expand all | Expand 10 after
2225 // Check for the hole value. 2225 // Check for the hole value.
2226 if (instr->hydrogen()->RequiresHoleCheck()) { 2226 if (instr->hydrogen()->RequiresHoleCheck()) {
2227 __ cmp(result, factory()->the_hole_value()); 2227 __ cmp(result, factory()->the_hole_value());
2228 DeoptimizeIf(equal, instr->environment()); 2228 DeoptimizeIf(equal, instr->environment());
2229 } 2229 }
2230 } 2230 }
2231 2231
2232 2232
2233 void LCodeGen::DoLoadKeyedFastDoubleElement( 2233 void LCodeGen::DoLoadKeyedFastDoubleElement(
2234 LLoadKeyedFastDoubleElement* instr) { 2234 LLoadKeyedFastDoubleElement* instr) {
2235 Register elements = ToRegister(instr->elements());
2236 XMMRegister result = ToDoubleRegister(instr->result()); 2235 XMMRegister result = ToDoubleRegister(instr->result());
2237 2236
2238 if (instr->hydrogen()->RequiresHoleCheck()) { 2237 if (instr->hydrogen()->RequiresHoleCheck()) {
2239 int offset = FixedDoubleArray::kHeaderSize - kHeapObjectTag + 2238 int offset = FixedDoubleArray::kHeaderSize - kHeapObjectTag +
2240 sizeof(kHoleNanLower32); 2239 sizeof(kHoleNanLower32);
2241 Operand hole_check_operand = BuildFastArrayOperand( 2240 Operand hole_check_operand = BuildFastArrayOperand(
2242 instr->elements(), instr->key(), 2241 instr->elements(), instr->key(),
2243 JSObject::FAST_DOUBLE_ELEMENTS, 2242 JSObject::FAST_DOUBLE_ELEMENTS,
2244 offset); 2243 offset);
2245 __ cmp(hole_check_operand, Immediate(kHoleNanUpper32)); 2244 __ cmp(hole_check_operand, Immediate(kHoleNanUpper32));
(...skipping 844 matching lines...) Expand 10 before | Expand all | Expand 10 after
3090 times_pointer_size, 3089 times_pointer_size,
3091 FixedArray::kHeaderSize)); 3090 FixedArray::kHeaderSize));
3092 __ RecordWrite(elements, key, value); 3091 __ RecordWrite(elements, key, value);
3093 } 3092 }
3094 } 3093 }
3095 3094
3096 3095
3097 void LCodeGen::DoStoreKeyedFastDoubleElement( 3096 void LCodeGen::DoStoreKeyedFastDoubleElement(
3098 LStoreKeyedFastDoubleElement* instr) { 3097 LStoreKeyedFastDoubleElement* instr) {
3099 XMMRegister value = ToDoubleRegister(instr->value()); 3098 XMMRegister value = ToDoubleRegister(instr->value());
3100 Register elements = ToRegister(instr->elements());
3101 Register key = instr->key()->IsRegister() ? ToRegister(instr->key()) : no_reg; 3099 Register key = instr->key()->IsRegister() ? ToRegister(instr->key()) : no_reg;
3102 Label have_value; 3100 Label have_value;
3103 3101
3104 __ ucomisd(value, value); 3102 __ ucomisd(value, value);
3105 __ j(parity_odd, &have_value); // NaN. 3103 __ j(parity_odd, &have_value); // NaN.
3106 3104
3107 ExternalReference canonical_nan_reference = 3105 ExternalReference canonical_nan_reference =
3108 ExternalReference::address_of_canonical_non_hole_nan(); 3106 ExternalReference::address_of_canonical_non_hole_nan();
3109 __ movdbl(value, Operand::StaticVariable(canonical_nan_reference)); 3107 __ movdbl(value, Operand::StaticVariable(canonical_nan_reference));
3110 __ bind(&have_value); 3108 __ bind(&have_value);
(...skipping 1199 matching lines...) Expand 10 before | Expand all | Expand 10 after
4310 env->deoptimization_index()); 4308 env->deoptimization_index());
4311 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4309 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4312 } 4310 }
4313 4311
4314 4312
4315 #undef __ 4313 #undef __
4316 4314
4317 } } // namespace v8::internal 4315 } } // namespace v8::internal
4318 4316
4319 #endif // V8_TARGET_ARCH_IA32 4317 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698