Issue 7491041: remove dead code in fast double elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7491041: remove dead code in fast double elements (Closed)

Created:
9 years, 5 months ago by wingo

Modified:
9 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

remove dead code in fast double elements * src/x64/lithium-codegen-x64.cc (DoLoadKeyedFastDoubleElement) (DoStoreKeyedFastDoubleElement): Remove set but unused variables. BUG= TEST=Fixes a build with gcc-4.6. Committed: http://code.google.com/p/v8/source/detail?r=8738

Patch Set 1 #

Patch Set 2 : make #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	src/ia32/lithium-codegen-ia32.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
	M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

Analogous dead code also exists on ia32. Can you please expand the patch to include ...

9 years, 5 months ago (2011-07-25 11:41:08 UTC) #3

wingo

9 years, 5 months ago (2011-07-25 12:40:59 UTC) #4

On 2011/07/25 11:41:08, danno wrote:
> Analogous dead code also exists on ia32. Can you please expand the patch to
> include those as well so that the platforms remain in sync?

Done.  It looks fine, but I still need to set up a 32-bit build machine, so
please make sure it compiles before pushing.  I'll set up the 32-bit machine
shortly so hopefully this is the only time I'll ask for that...

Expand Messages | Collapse Messages