Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 7491034: Fix look of close button in new tab page (Closed)

Created:
9 years, 5 months ago by sail
Modified:
9 years, 5 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix look of close button in new tab page In r93569 I added the sync promo UI to the new tab page. This caused the section close buttons in the new tab page to look weird. The problem was due to me including button.css. This file changes the look for all buttons. For now I'm just removing the button.css include. BUG=90286 TEST=Ran and verified that the close button looked ok. TBR=jhawkins Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/new_tab.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sail
9 years, 5 months ago (2011-07-23 22:12:12 UTC) #1
James Hawkins
Won't this cause the buttons in the gaia login code to look wrong?
9 years, 5 months ago (2011-07-23 22:35:50 UTC) #2
sail
On 2011/07/23 22:35:50, James Hawkins wrote: > Won't this cause the buttons in the gaia ...
9 years, 5 months ago (2011-07-23 22:52:09 UTC) #3
James Hawkins
On 2011/07/23 22:52:09, sail wrote: > On 2011/07/23 22:35:50, James Hawkins wrote: > > Won't ...
9 years, 5 months ago (2011-07-23 22:54:29 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-23 23:58:33 UTC) #5
Change committed as 93814

Powered by Google App Engine
This is Rietveld 408576698