ARM: Fast path for compare against constant.

src/arm/constants-arm.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 158 matching lines @@
     case ge:
       return le;
     case le:
       return ge;
     default:
       return cond;
   };
 }
 
 
+inline bool EvalComparison(Condition cond, double op1, double op2) {

[Mads Ager (chromium), 2011/07/27 13:05:05]

Why not have this in the code generator and switch on the token instead of going
from token to condition to operation?

[Alexandre, 2011/07/28 13:42:16]

Done.

+  switch (cond) {
+    case eq: return (op1 == op2);
+    case ne: return (op1 != op2);
+    case lt: return (op1 < op2);
+    case gt: return (op1 > op2);
+    case le: return (op1 <= op2);
+    case ge: return (op1 >= op2);
+    default:
+      UNREACHABLE();
+      return false;
+  }
+}
+
+
 // -----------------------------------------------------------------------------
 // Instructions encoding.
 
 // Instr is merely used by the Assembler to distinguish 32bit integers
 // representing instructions from usual 32 bit values.
 // Instruction objects are pointers to 32bit values, and provide methods to
 // access the various ISA fields.
 typedef int32_t Instr;
 
 
@@ skipping 577 matching lines @@
   static int Number(const char* name, bool* is_double);
 
  private:
   static const char* names_[kNumVFPRegisters];
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_ARM_CONSTANTS_ARM_H_