Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7489044: Fix potential leak (Closed)

Created:
9 years, 5 months ago by joth
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix potential leak In the early return path from SendResponse, bytes may never be released. If it was only just constructed by the caller, then it could get leaked. BUG=None TEST=ChromeURLDataManagerTest still passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
joth
9 years, 5 months ago (2011-07-25 11:40:32 UTC) #1
sky
LGTM
9 years, 5 months ago (2011-07-25 14:09:13 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-25 15:54:17 UTC) #3
Change committed as 93888

Powered by Google App Engine
This is Rietveld 408576698