Issue 7489043: Better range information for logical shift right >>>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7489043: Better range information for logical shift right >>>. (Closed)

Created:
9 years, 5 months ago by fschneider

Modified:
9 years, 5 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Better range information for logical shift right >>>. If the input range is positive and the shift count is constant we can replace >>> with >> to compute the output range. For negative inputs, we can only compute a range if the result always fits into a signed int32. BUG=v8:1510 Committed: http://code.google.com/p/v8/source/detail?r=8735

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	src/hydrogen-instructions.h	View		2 chunks	+2 lines, -0 lines	1 comment	Download
	M	src/hydrogen-instructions.cc	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 5 months ago (2011-07-25 13:27:03 UTC) #2

LGTM.

http://codereview.chromium.org/7489043/diff/3004/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7489043/diff/3004/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:255: void Shr(int32_t value);
Unimplemented.

Expand Messages | Collapse Messages