Unify the version string to be displayed on "About Chromium" dialog. (3/6)

Unify the version string to be displayed on "About Chromium" dialog. (3/6)

- Refactor the views about dialog to use shared code for generating the version string.
- Remove the OS version string from the views about dialog because it is no longer needed to differentiate between Windows and ChromeOS.

We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the third step of them:

(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan, mark)
(5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark)
(6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark)

BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Windows)" on Windows.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94253

[haraken1, 2011-07-25 02:34:46]

davemoore, tony: Would you please take a look at it?
mark: FYI

[DaveMoore, 2011-07-25 17:04:19]

In chromeos the about chromium dialog is never displayed...we use the web ui.

[tony, 2011-07-25 17:04:50]

The code change LGTM, but please fix the description to describe only what this
change is doing.  Something like:

Unify the version string to be displayed on "About Chromium" dialog. (3/6)

- Refactor the views about dialog to use shared code for generating the version
string.
- Remove the OS version string from the views about dialog because it is no
longer needed to differentiate between Windows and ChromeOS.

BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like
"14.0.787.0 (Developer Build 88242 Windows)" on Windows.

[tony, 2011-07-25 17:05:48]

On 2011/07/25 17:04:19, DaveMoore wrote:
> In chromeos the about chromium dialog is never displayed...we use the web ui.

Correct, the code was never removed from the views dialog when we switched to
web ui.

[haraken1, 2011-07-25 21:49:51]

> In chromeos the about chromium dialog is never displayed...we use the web ui.

Yes, this change affects only Windows about dialog. I am waiting for davemoore's
LGTM. 

tony:
> The code change LGTM, but please fix the description to describe only what
this
> change is doing.  Something like:

Done.

[DaveMoore, 2011-07-26 23:32:09]

lgtm

[commit-bot: I haz the power, 2011-07-27 06:29:37]

Change committed as 94253