Fix up various browser tests not to use WaitForNavigation.

chrome/browser/sidebar/sidebar_browsertest.cc

Index: chrome/browser/sidebar/sidebar_browsertest.cc
diff --git a/chrome/browser/sidebar/sidebar_browsertest.cc b/chrome/browser/sidebar/sidebar_browsertest.cc
index 049857b0fade599c422d307ea61fe0d777d8755d..5f9835b79a09f6ed673b9c6e4364aa591511f050 100644
--- a/chrome/browser/sidebar/sidebar_browsertest.cc
+++ b/chrome/browser/sidebar/sidebar_browsertest.cc
@@ -72,13 +72,14 @@ class SidebarTest : public ExtensionBrowserTest {
 
     SidebarManager* sidebar_manager = SidebarManager::GetInstance();
 
+    ui_test_utils::WindowedNotificationObserver observer(tab->controller());

[Paweł Hajdan Jr., 2011/08/04 17:56:48]

Looks like you may need to update this call site to use the existing ctor.

[Greg Billock, 2011/08/11 22:57:45]

Yeah, a try caught that, too. It's changed and uploaded.

     sidebar_manager->NavigateSidebar(tab, content_id_, url);
+    observer.Wait();
 
     SidebarContainer* sidebar_container =

[Paweł Hajdan Jr., 2011/08/04 17:56:48]

nit: Looks like this could be removed now, below too.

[Greg Billock, 2011/08/11 22:57:45]

Done.

         sidebar_manager->GetSidebarContainerFor(tab, content_id_);
 
     TabContents* client_contents = sidebar_container->sidebar_contents();
-    ui_test_utils::WaitForNavigation(&client_contents->controller());
   }
 
   void ShowSidebar(TabContents* tab) {
@@ -199,4 +200,3 @@ IN_PROC_BROWSER_TEST_F(SidebarTest, SidebarNavigate) {
 }
 
 }  // namespace
-