Issue 7489005: Fixed an off-by-one error in SplitConstantsInFullCompiler test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7489005: Fixed an off-by-one error in SplitConstantsInFullCompiler test. (Closed)

Created:
9 years, 5 months ago by Sven Panne

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium), danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed an off-by-one error in SplitConstantsInFullCompiler test. The test tried to disassemble the last entry in a constant pool, which only worked by accident until address randomization was introduced. Committed: http://code.google.com/p/v8/source/detail?r=8717

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	test/cctest/test-compiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM! Thanks Sven!

Expand Messages | Collapse Messages