Virtual Cloud Print Driver for Mac.

chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc

Index: chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc
diff --git a/chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc b/chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ea051f8b4ea2a364dd4f6e7cd51afd4d9cb7bdce
--- /dev/null
+++ b/chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc
@@ -0,0 +1,43 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/printing/cloud_print/virtual_driver_install_helper.h"

[Nico, 2011/08/01 21:31:12]

One newline here. The standard format is

#include "header_file_for_this_cc.cc"

one include block for all the other includes

[abeera, 2011/08/02 01:21:02]

Done.

+#include "chrome/browser/service/service_process_control.h"
+#include "chrome/common/service_messages.h"
+
+namespace cloud_print {
+
+void VirtualDriverInstallHelper::SetUpInstall() {
+  scoped_refptr<VirtualDriverInstallHelper> help =

[Nico, 2011/08/01 21:31:12]

NewRunnableMethod() retains its argument, so no need for a scoped_refptr here I
think.

Can't you do

  ServiceProcessControl* service = ServiceProcessControl::GetInstance();
  service->Launch()(NewRunnableMethod(service, ServiceProcessControl::Send, new
ServiceMsg_EnableVirtualDriver()));

? Then you don't need the temporary object and the method. (if all callers of
Launch() just end up calling methods on SPC anyway, Launch() should get a set of
flags, not a callable)

[abeera, 2011/08/02 01:21:02]

To post a task, a class needs to extend from RefCountedThreadSafe, which
ServiceProcessControl does not. So, I felt that using this forwarding class was
the best way to do things.
I tried to change it to not use scoped_refptr, however the browser crashed:  it
is needed.
On 2011/08/01 21:31:12, Nico wrote:

+      new VirtualDriverInstallHelper();
+  ServiceProcessControl::GetInstance()->Launch(
+      NewRunnableMethod(
+          help.get(), &VirtualDriverInstallHelper::InstallVirtualDriverTask),
+      NULL);
+}
+
+void VirtualDriverInstallHelper::SetUpUninstall() {
+  scoped_refptr<VirtualDriverInstallHelper> help =
+      new VirtualDriverInstallHelper();
+  ServiceProcessControl::GetInstance()->Launch(
+      NewRunnableMethod(
+          help.get(), &VirtualDriverInstallHelper::UninstallVirtualDriverTask),
+      NULL);
+}
+
+void VirtualDriverInstallHelper::InstallVirtualDriverTask() {
+  ServiceProcessControl* process_control =
+      ServiceProcessControl::GetInstance();
+  DCHECK(process_control->is_connected());
+  process_control->Send(new ServiceMsg_EnableVirtualDriver());
+}
+
+void VirtualDriverInstallHelper::UninstallVirtualDriverTask() {
+  ServiceProcessControl* process_control =
+      ServiceProcessControl::GetInstance();
+  DCHECK(process_control->is_connected());
+  process_control->Send(new ServiceMsg_DisableVirtualDriver());
+}
+
+} // namespace cloud_print