content/common/cloud_print_class_mac.h - Issue 7485011: Virtual Cloud Print Driver for Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/cloud_print_class_mac.h

Issue 7485011: Virtual Cloud Print Driver for Mac. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Style fixes. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_CLOUD_PRINT_CLASS_MAC_H_

	6 #define CONTENT_COMMON_CLOUD_PRINT_CLASS_MAC_H_

	7 #pragma once

	8

	9 #import <AppKit/AppKit.h>

	10

	11 // Four character constant to identify Cloud print IPC call.

	12 extern const AEEventClass cloudPrintClass;
	brettw 2011/08/05 23:15:18 Is this the correct style for this name? I'm not s Is this the correct style for this name? I'm not so familar with Obj-C style, but I would expect this to use more Google-standard constant naming (kCloudPrintClass). Something more specific like kCloudPrintAEEventClass might be better for this global constant. I'd feel better if this was in the content namespace. We do this for many of the constants in common to keep them out of the global namespace. abeera 2011/08/08 17:12:14 Done. Show quoted text On 2011/08/05 23:15:18, brettw wrote: > Is this the correct style for this name? I'm not so familar with Obj-C style, > but I would expect this to use more Google-standard constant naming > (kCloudPrintClass). Something more specific like kCloudPrintAEEventClass might > be better for this global constant. > > I'd feel better if this was in the content namespace. We do this for many of the > constants in common to keep them out of the global namespace. Done.
	13

	14 #endif // CONTENT_COMMON_CLOUD_PRINT_CLASS_MAC_H_

	15

OLD	NEW

« no previous file with comments | « cloud_print/virtual_driver/virtual_driver_posix.gyp ('k') | content/common/cloud_print_class_mac.mm » ('j') | no next file with comments »