Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: chrome/browser/content_settings/host_content_settings_map.cc

Issue 7484072: Migrate geolocation settings to host content settings map. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/host_content_settings_map.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map.cc b/chrome/browser/content_settings/host_content_settings_map.cc
index b0e4daeb306758954528294a91be593ebb5a6189..3b38fb0784feb02de2cde853a3cd86b2a65bcb55 100644
--- a/chrome/browser/content_settings/host_content_settings_map.cc
+++ b/chrome/browser/content_settings/host_content_settings_map.cc
@@ -311,19 +311,20 @@ void HostContentSettingsMap::GetSettingsForOneType(
content_settings_providers_[i]->GetAllContentSettingsRules(
content_type, resource_identifier, &rules);
- // Sort rules according to their primary pattern string using a map.
- std::map<std::string, PatternSettingSourceTuple> settings_map;
+ // Sort rules according to their primary pattern string using a multimap.
Bernhard Bauer 2011/08/10 13:04:03 What's the reason for this change?
+ std::multimap<std::string, PatternSettingSourceTuple> settings_map;
for (Rules::iterator rule = rules.begin();
rule != rules.end();
++rule) {
- // We do not support pattern pairs in the UI, so we only display the
- // primary pattern.
std::string sort_key = rule->primary_pattern.ToString();
- settings_map[sort_key] = PatternSettingSourceTuple(
- rule->primary_pattern,
- rule->secondary_pattern,
- rule->content_setting,
- kProviderNames[i]);
+ std::pair<std::string, PatternSettingSourceTuple> map_entry(
+ sort_key,
+ PatternSettingSourceTuple(rule->primary_pattern,
+ rule->secondary_pattern,
+ rule->content_setting,
+ kProviderNames[i]));
+
+ settings_map.insert(map_entry);
}
// TODO(markusheintz): Only the rules that are applied should be added.

Powered by Google App Engine
This is Rietveld 408576698