Migrate geolocation settings to host content settings map.

Migrate geolocation settings to host content settings map and remove the geolocation settings map.

BUG=63656
TEST=host_content_settings_map_unittest.cc,
     content_settings_pref_provider_unittest.cc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96808

[markusheintz_, 2011-08-02 16:22:55]

Please review my CL. Thanks!

[Bernhard Bauer, 2011-08-03 15:22:50]

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:86: void
CopyKeys(DictionaryValue* source,
Not used?

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1077: for
(size_t i = 0; i <= CONTENT_SETTINGS_TYPE_POPUPS; ++i) {
Can you start the iteration at CONTENT_SETTINGS_TYPE_COOKIES?

Also, if you move this loop to the top level, you don't need to loop over
|settings_dictionary| anymore (just look up |kTypeNames[i]| in there).

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1078: if
((kTypeNames[i] != NULL) && (kTypeNames[i] == type_name)) {
kTypeNames[i] should never be NULL.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1079: Value*
value;
Initialize to NULL please.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1117:
geolocation_settings_dictionary->GetDictionaryWithoutPathExpansion(
Maybe this is an indication to use a shorter variable name? For example, the
|_dictionary| part is implied by the type of the variable.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1167:
DictionaryValue* settings_dictionary;
Initialize with NULL please.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1183:
DictionaryValue* one_origin_settings;
Initialize with NULL please (not as important here, but coverity might still
complain otherwise).

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1198:
prefs_->Set(prefs::kGeolocationContentSettings,
Is there a reason you're not using a DictionaryPrefUpdate?

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.h (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.h:152: // persist
content settigns exceptions and supposed to replace the preferences
Nit: "settings".

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.h:183: // Copies
geolocation content settings exceptions to the obsolete preference
Can you explain that it copies from the new preference to the obsolete one?

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.h:185: //
geolocation content settings exceptions beeing synced to older versions of
Nit: "being"

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_settings_state.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_settings_state.cc:89:
profile_->GetHostContentSettingsMap()->GetContentSetting(
Nit: indent one more space.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:161: new
StringValue(GeolocationExceptionToString(origin, embedding_origin)));
While you're here, could you change this to use SetString?

[markusheintz_, 2011-08-04 12:45:56]

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:86: void
CopyKeys(DictionaryValue* source,
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Not used?

Sorry. Removed!

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1077: for
(size_t i = 0; i <= CONTENT_SETTINGS_TYPE_POPUPS; ++i) {
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Can you start the iteration at CONTENT_SETTINGS_TYPE_COOKIES?
> 
> Also, if you move this loop to the top level, you don't need to loop over
> |settings_dictionary| anymore (just look up |kTypeNames[i]| in there).

s/0/CONTENT_SETTINGS_TYPE_COOKIES/ and changed the loops like you suggested.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1078: if
((kTypeNames[i] != NULL) && (kTypeNames[i] == type_name)) {
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> kTypeNames[i] should never be NULL.

I replaced the (kTypeNames[i] != NULL)with a DCHECK(kTypeNames[i]) in the
modified code.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1079: Value*
value;
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Initialize to NULL please.

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1117:
geolocation_settings_dictionary->GetDictionaryWithoutPathExpansion(
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Maybe this is an indication to use a shorter variable name? For example, the
> |_dictionary| part is implied by the type of the variable.

I removed the trailing |_dictionary| from the names.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1167:
DictionaryValue* settings_dictionary;
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Initialize with NULL please.

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1183:
DictionaryValue* one_origin_settings;
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Initialize with NULL please (not as important here, but coverity might still
> complain otherwise).

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1198:
prefs_->Set(prefs::kGeolocationContentSettings,
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Is there a reason you're not using a DictionaryPrefUpdate?

I just found that shorter.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.h (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.h:152: // persist
content settigns exceptions and supposed to replace the preferences
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Nit: "settings".

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.h:183: // Copies
geolocation content settings exceptions to the obsolete preference
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Can you explain that it copies from the new preference to the obsolete one?

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.h:185: //
geolocation content settings exceptions beeing synced to older versions of
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Nit: "being"

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_settings_state.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_settings_state.cc:89:
profile_->GetHostContentSettingsMap()->GetContentSetting(
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> Nit: indent one more space.

Done.

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:161: new
StringValue(GeolocationExceptionToString(origin, embedding_origin)));
On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> While you're here, could you change this to use SetString?

Absolutely!

[Bernhard Bauer, 2011-08-05 10:08:45]

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/9020/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:1198:
prefs_->Set(prefs::kGeolocationContentSettings,
On 2011/08/04 12:45:56, markusheintz_ wrote:
> On 2011/08/03 15:22:50, Bernhard Bauer wrote:
> > Is there a reason you're not using a DictionaryPrefUpdate?
> 
> I just found that shorter.

OTOH, it makes a |DeepCopy| of the dictionary.

http://codereview.chromium.org/7484072/diff/23001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1093: //
Existing values are overwritten.
Nit: indent four spaces less now.

http://codereview.chromium.org/7484072/diff/23001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1106:
prefs_->GetDictionary(prefs::kGeolocationContentSettings);
Nit: indent four spaces less now.

[markusheintz_, 2011-08-09 13:45:47]

I fixed all comments but re-added a method to update the obsolete geolocation
preference. Since I use the SetContentSettings method on the
MigrateGeolocationSettings method I need the additional update method to avoid
segfaults.

http://codereview.chromium.org/7484072/diff/23001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/23001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1093:
primary_key, &requesting_origin_settings);
On 2011/08/05 10:08:46, Bernhard Bauer wrote:
> Nit: indent four spaces less now.

Done.

http://codereview.chromium.org/7484072/diff/23001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1106:
secondary_key, &setting_value);
On 2011/08/05 10:08:46, Bernhard Bauer wrote:
> Nit: indent four spaces less now.

Done.

[Bernhard Bauer, 2011-08-09 14:09:45]

On 2011/08/09 13:45:47, markusheintz_ wrote:
> I fixed all comments but re-added a method to update the obsolete geolocation
> preference. Since I use the SetContentSettings method on the
> MigrateGeolocationSettings method I need the additional update method to avoid
> segfaults.

Segfaults? I don't understand.

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:86: void
CopyKeys(DictionaryValue* source,
Didn't you already delete this?

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:880: if
(requesting_origin_settings_dictionary->empty())
Nit: curlies please.

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1184: {
Nit: No need for the additional scope.

[markusheintz_, 2011-08-09 14:40:49]

The "MigrateObsoleteGeolocationPref" method uses the "SetContentSetting" method
while iterating over the obsolete prefs dictionary. The "SetContentSettings"
method calls the "UpdatePref" method which used to call SyncObsoletePreferences
which clears the obsolete prefs dictionary => crash.

All this happen because I removed the "UpdateObsoleteGeolocation" method form an
earlier version of this CL (#7) to save some lines of code (bad idea).

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:86: void
CopyKeys(DictionaryValue* source,
On 2011/08/09 14:09:45, Bernhard Bauer wrote:
> Didn't you already delete this?

*Grrrr* to myself. Sorry that sneaked back in with the method (which I had in an
earlier version of this CL) below.

Removed.

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:880: if
(requesting_origin_settings_dictionary->empty())
On 2011/08/09 14:09:45, Bernhard Bauer wrote:
> Nit: curlies please.

Done.

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1184: {
On 2011/08/09 14:09:45, Bernhard Bauer wrote:
> Nit: No need for the additional scope.

Done.

[Bernhard Bauer, 2011-08-09 14:57:33]

On 2011/08/09 14:40:49, markusheintz_ wrote:
> The "MigrateObsoleteGeolocationPref" method uses the "SetContentSetting"
method
> while iterating over the obsolete prefs dictionary. The "SetContentSettings"
> method calls the "UpdatePref" method which used to call
SyncObsoletePreferences
> which clears the obsolete prefs dictionary => crash.
> 
> All this happen because I removed the "UpdateObsoleteGeolocation" method form
an
> earlier version of this CL (#7) to save some lines of code (bad idea).

OK... I think I know what you mean. Could you make Sync... call Update...
though? That might reduce the amount of code a little again :-)

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1184: {
On 2011/08/09 14:40:49, markusheintz_ wrote:
> On 2011/08/09 14:09:45, Bernhard Bauer wrote:
> > Nit: No need for the additional scope.
> 
> Done.

Um, no. Scope, not empty line :-)

[markusheintz_, 2011-08-10 09:33:05]

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1184: {
On 2011/08/09 14:57:33, Bernhard Bauer wrote:
> On 2011/08/09 14:40:49, markusheintz_ wrote:
> > On 2011/08/09 14:09:45, Bernhard Bauer wrote:
> > > Nit: No need for the additional scope.
> > 
> > Done.
> 
> Um, no. Scope, not empty line :-)

Uups ... I guess I just read "nit" and stopped reading then guessing the rest of
the line.

Done now. :)

[Bernhard Bauer, 2011-08-10 10:40:03]

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/30001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1184: {
On 2011/08/10 09:33:05, markusheintz_ wrote:
> On 2011/08/09 14:57:33, Bernhard Bauer wrote:
> > On 2011/08/09 14:40:49, markusheintz_ wrote:
> > > On 2011/08/09 14:09:45, Bernhard Bauer wrote:
> > > > Nit: No need for the additional scope.
> > > 
> > > Done.
> > 
> > Um, no. Scope, not empty line :-)
> 
> Uups ... I guess I just read "nit" and stopped reading then guessing the rest
of
> the line.

:-D

> Done now. :)

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1211: int
setting_value;
Oh, wait, we use UpdateObsoleteGeolocationPref now? In that case, you could just
|ClearPref(prefs::kGeolocationContentSettings)|.

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1227:
secondary_url.spec(), Value::CreateIntegerValue(setting_value));
Nit: indentation

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1236: 
Nit: indentation.

[markusheintz_, 2011-08-10 11:21:42]

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1211:
obsolete_geolocation_settings->Clear();
On 2011/08/10 10:40:03, Bernhard Bauer wrote:
> Oh, wait, we use UpdateObsoleteGeolocationPref now? In that case, you could
just
> |ClearPref(prefs::kGeolocationContentSettings)|.

Done.

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1227: key,
&settings_dictionary);
On 2011/08/10 10:40:03, Bernhard Bauer wrote:
> Nit: indentation

Done.

http://codereview.chromium.org/7484072/diff/38001/chrome/browser/content_sett...
chrome/browser/content_settings/content_settings_pref_provider.cc:1236:
UpdateObsoleteGeolocationPref(
On 2011/08/10 10:40:03, Bernhard Bauer wrote:
> Nit: indentation.

Done.

[Bernhard Bauer, 2011-08-10 11:55:28]

http://codereview.chromium.org/7484072/diff/4006/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/4006/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:562:
AutoReset<bool> auto_reset(&updating_preferences_, true);
Nit: Move this (and the ones below) out of the if-block directly after the check
whether it's already set?

Likewise, you could move |ReadContentSettingsFromPref| below the block.

[markusheintz_, 2011-08-10 12:47:53]

http://codereview.chromium.org/7484072/diff/4006/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/7484072/diff/4006/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:562:
AutoReset<bool> auto_reset(&updating_preferences_, true);
On 2011/08/10 11:55:29, Bernhard Bauer wrote:
> Nit: Move this (and the ones below) out of the if-block directly after the
check
> whether it's already set?
> 
> Likewise, you could move |ReadContentSettingsFromPref| below the block.

Done.

[Bernhard Bauer, 2011-08-10 13:04:03]

http://codereview.chromium.org/7484072/diff/38030/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/7484072/diff/38030/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.cc:314: // Sort rules
according to their primary pattern string using a multimap.
What's the reason for this change?

[markusheintz_, 2011-08-10 14:08:15]

@sail: Could you review the profile related changes of the CL? Thanks a lot.

[sail, 2011-08-10 16:06:51]

LGTM

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.cc (right):

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.cc:9: #include <vector>
Same here, not sure why this is needed.

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.h (right):

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.h:11: #include <string>
Hm.. why did this need to be added?

[markusheintz_, 2011-08-11 12:30:38]

@Bernhard: I worked on the changes we discussed offline.

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.cc (right):

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.cc:9: #include <vector>
On 2011/08/10 16:06:51, sail wrote:
> Same here, not sure why this is needed.

Lint complained that std::list, std::vector and std::pair are
used in this file but not included. So I thought I might add them. But since
they are not related to my change I removed them again.

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.h (right):

http://codereview.chromium.org/7484072/diff/12004/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.h:11: #include <string>
On 2011/08/10 16:06:51, sail wrote:
> Hm.. why did this need to be added?

Same as in the other case.
I removed this again.

[Bernhard Bauer, 2011-08-11 12:35:33]

LGTM, thanks!

[markusheintz_, 2011-08-11 12:44:54]

Thanks all for the review!

[commit-bot: I haz the power, 2011-08-12 12:09:58]

Presubmit check for 7484072-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: content/browser/browser_context.h

Presubmit checks took 2.3s to calculate.

[markusheintz_, 2011-08-12 12:15:18]

@Avi: Could you please review the content/browser/browser_context.h related
changes? Thanks a lot

[Avi (use Gerrit), 2011-08-15 17:35:20]

On 2011/08/12 12:15:18, markusheintz_ wrote:
> @Avi: Could you please review the content/browser/browser_context.h related
> changes? Thanks a lot

OWNER rubberstamp

[commit-bot: I haz the power, 2011-08-15 17:42:20]

Presubmit check for 7484072-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: content/browser/browser_context.h

Presubmit checks took 1.5s to calculate.

[Avi (use Gerrit), 2011-08-15 17:44:29]

Rubberstamp LGTM

[commit-bot: I haz the power, 2011-08-15 19:27:32]

Change committed as 96808