Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 7484063: Add a browser-test for downloading an anchor with a suggested name for download. (Closed)

Created:
9 years, 5 months ago by sadrul
Modified:
9 years, 4 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a browser-test for downloading an anchor with a suggested name for download. BUG=89346 TEST=DownloadTest.AnchorDownloadTag Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/test/data/download-anchor-attrib.html View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sadrul
The parent CLs for this test hasn't landed yet. I will make sure the tests ...
9 years, 5 months ago (2011-07-26 21:56:26 UTC) #1
Randy Smith (Not in Mondays)
Asanka, could you review this? I'll rubber stamp once you're ok with it.
9 years, 5 months ago (2011-07-27 15:44:08 UTC) #2
sadrul
The necessary webkit patches have been rolled in, and the test seems to be passing ...
9 years, 5 months ago (2011-07-27 20:19:11 UTC) #3
asanka
LGTM.
9 years, 5 months ago (2011-07-27 20:41:35 UTC) #4
sadrul
tryjob on ChromiumOS for this test: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/11436
9 years, 5 months ago (2011-07-27 21:57:43 UTC) #5
Randy Smith (Not in Mondays)
On 2011/07/27 20:41:35, asanka wrote: > LGTM.
9 years, 4 months ago (2011-07-28 15:08:04 UTC) #6
Randy Smith (Not in Mondays)
On 2011/07/28 15:08:04, rdsmith wrote: > On 2011/07/27 20:41:35, asanka wrote: > > LGTM. That ...
9 years, 4 months ago (2011-07-28 15:08:30 UTC) #7
sadrul
9 years, 4 months ago (2011-07-28 15:12:22 UTC) #8
Thanks!

Powered by Google App Engine
This is Rietveld 408576698