Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 7484062: Update chromite wrapper (Closed)

Created:
9 years, 5 months ago by zbehan
Modified:
9 years, 5 months ago
Reviewers:
rcui, M-A Ruel, anush
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Update chromite wrapper * Add a new version of the chromite wrapper as chromite_wrapper * Create symlinks (chromite, cros_sdk, cbuildbot) pointing to it TEST=inside repo checkout, run cros_sdk, chromite, cbuildbot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94011

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -84 lines) Patch
A cbuildbot View 1 chunk +1 line, -0 lines 0 comments Download
R chromite View 1 chunk +1 line, -84 lines 0 comments Download
A chromite_wrapper View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A cros_sdk View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zbehan
9 years, 5 months ago (2011-07-24 21:46:43 UTC) #1
M-A Ruel
lgtm!
9 years, 5 months ago (2011-07-25 01:36:18 UTC) #2
zbehan
OK, sorry about that. I accidentally uploaded a locally modified version of chromite_wrapper. This one ...
9 years, 5 months ago (2011-07-25 04:56:59 UTC) #3
zbehan
9 years, 5 months ago (2011-07-26 01:10:40 UTC) #4
OK, last iteration of this CL, added a new version of chromite_wrapper, that
finally supports cbuildbot correctly. Repeated tests.

chromite_wrapper is reviewed already (CL about to be pushed) and this is merely
copying the authoritative version again.

I decided it's better to do both changes at once.

Powered by Google App Engine
This is Rietveld 408576698