media/base/mock_filters.cc - Issue 7484054: Migrate Pipeline & PipelineImpl to PipelineStatusCB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/mock_filters.cc

Issue 7484054: Migrate Pipeline & PipelineImpl to PipelineStatusCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix CR nits Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/mock_filters.cc

diff --git a/media/base/mock_filters.cc b/media/base/mock_filters.cc

index 6fe84c37255209269a80a6f3e0428479179b6976..07466a1877649a88920d850b7054be26f0e18ea2 100644

--- a/media/base/mock_filters.cc

+++ b/media/base/mock_filters.cc

@@ -173,10 +173,8 @@ void RunFilterStatusCB(::testing::Unused, const FilterStatusCB& cb) {

cb.Run(PIPELINE_OK);

}

-void RunPipelineStatusCallback(

- PipelineStatus status, PipelineStatusCallback* callback) {

- callback->Run(status);

- delete callback;

+void RunPipelineStatusCB(PipelineStatus status, const PipelineStatusCB& cb) {

+ cb.Run(status);

}

void RunFilterCallback3(::testing::Unused, FilterCallback* callback,

« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.h » ('j') | no next file with comments »