Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2559)

Unified Diff: base/test/test_file_util_mac.cc

Issue 7484052: Return true when file size is zero. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix according to code review. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_file_util_mac.cc
diff --git a/base/test/test_file_util_mac.cc b/base/test/test_file_util_mac.cc
index 316b5c3d01aa9aec7c42d64bce64be95cd0b0969..7d01db2fa0c5af2bbdb712e41dad1c85ceb0d408 100644
--- a/base/test/test_file_util_mac.cc
+++ b/base/test/test_file_util_mac.cc
@@ -17,6 +17,16 @@ bool EvictFileFromSystemCache(const FilePath& file) {
// default) + MAP_SHARED, then do an msync to invalidate the memory. The next
// open should then have to load the file from disk.
+ int64 length;
+ if (!file_util::GetFileSize(file, &length)) {
kkania 2011/07/23 00:27:02 now that I think about it, I'm not sure this is co
TVL 2011/07/25 12:40:10 If the OS cache had that sort of bugs/behaviors, y
+ DLOG(WARNING) << "failed to get size of " << file.value();
+ return false;
+ }
+
+ // When a file is empty, we do not need to purge it.
kkania 2011/07/23 00:23:31 maybe include that mapping it would cause an error
+ if (!length)
+ return true;
+
file_util::MemoryMappedFile mapped_file;
if (!mapped_file.Initialize(file)) {
DLOG(WARNING) << "failed to memory map " << file.value();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698