Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: base/test/test_file_util_mac.cc

Issue 7484052: Return true when file size is zero. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_file_util_mac.cc
diff --git a/base/test/test_file_util_mac.cc b/base/test/test_file_util_mac.cc
index 316b5c3d01aa9aec7c42d64bce64be95cd0b0969..409781cea9bcdedc2bbc34daa737a93f1509e308 100644
--- a/base/test/test_file_util_mac.cc
+++ b/base/test/test_file_util_mac.cc
@@ -17,6 +17,12 @@ bool EvictFileFromSystemCache(const FilePath& file) {
// default) + MAP_SHARED, then do an msync to invalidate the memory. The next
// open should then have to load the file from disk.
+ int64 length;
kkania 2011/07/22 23:48:58 add a comment why this is needed
Huyen 2011/07/23 00:00:36 Done.
+ file_util::GetFileSize(file, &length);
kkania 2011/07/22 23:48:58 This could fail. log a warning and return false.
Huyen 2011/07/23 00:00:36 Done.
+ if (length == 0) {
kkania 2011/07/22 23:48:58 if (!length) return true;
Huyen 2011/07/23 00:00:36 Done.
+ return true;
+ }
+
file_util::MemoryMappedFile mapped_file;
if (!mapped_file.Initialize(file)) {
DLOG(WARNING) << "failed to memory map " << file.value();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698