Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 7484002: Fix git-cl --contributor flag support for presubmit checks. (Closed)

Created:
9 years, 5 months ago by M-A Ruel
Modified:
9 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Fix git-cl --contributor flag support for presubmit checks. Chromium's presubmit check assumes the author is an email address. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93645

Patch Set 1 #

Patch Set 2 : fix regexp #

Patch Set 3 : Fixed whth --contributor is not used, duh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M gclient.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gclient_scm.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M git_cl.py View 1 2 4 chunks +10 lines, -5 lines 0 comments Download
M tests/gclient_scm_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 5 months ago (2011-07-21 19:19:10 UTC) #1
Dirk Pranke
9 years, 5 months ago (2011-07-21 20:31:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698