Removed separator in bookmarks sub-menu if there are no bookmarks or folders to display (only fix...

chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
===================================================================
--- chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	(revision 93451)
+++ chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	(working copy)
@@ -358,6 +358,12 @@
                                      int* next_menu_id) {
   DCHECK(!parent->child_count() ||
          start_child_index < parent->child_count());
+
+  if ((start_child_index < parent->child_count()) &&

[sky, 2011/07/22 21:09:09]

Couple of problems with this:
I don't like putting this check in a spot that is recursively called when all we
really care about is the first menu. It should be around line 67.
GetSubmenu can return null.
This doesn't deal with the case of there be no bookmarks on the bookmark bar,
but bookmarks in the other folder.

+      (menu->GetSubmenu()->GetMenuItemCount() > 0)) {
+    menu->AppendSeparator();
+  }
+
   for (int i = start_child_index; i < parent->child_count(); ++i) {
     const BookmarkNode* node = parent->GetChild(i);
     int id = *next_menu_id;