Removed separator in bookmarks sub-menu if there are no bookmarks or folders to display (only fix...

chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
===================================================================
--- chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	(revision 93383)
+++ chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	(working copy)
@@ -358,6 +358,12 @@
                                      int* next_menu_id) {
   DCHECK(!parent->child_count() ||
          start_child_index < parent->child_count());
+
+  if ((start_child_index < parent->child_count()) &&
+     (parent == profile_->GetBookmarkModel()->GetBookmarkBarNode())) {
+     menu->AppendSeparator();
+  }
+

[Roger Tawa OOO till Jul 10th, 2011/07/21 20:41:48]

I think it would be better to check if the menu argument has a submenu and if
that submenu already has more than one child.  If both conditions are true, then
add the separator.   What do you think?

fyi, please take a look at the coding style at
http://www.chromium.org/developers/coding-style.  The style says that line 363
would need to be indented one space more, and line 364 would need to be indented
one space less.

[Roger Tawa OOO till Jul 10th, 2011/07/21 20:43:54]

Sorry, meant to say "one or more children", not "more than one child".

   for (int i = start_child_index; i < parent->child_count(); ++i) {
     const BookmarkNode* node = parent->GetChild(i);
     int id = *next_menu_id;