Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: net/server/web_socket.h

Issue 7482041: DevTools: no way to remote debug using ToT build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: web_socket class was extracted. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/server/web_socket.h
diff --git a/net/server/web_socket.h b/net/server/web_socket.h
new file mode 100644
index 0000000000000000000000000000000000000000..a74b9010dcc2f3a93e8a18a225cded331c366042
--- /dev/null
+++ b/net/server/web_socket.h
@@ -0,0 +1,43 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SERVER_WEB_SOCKET_H_
+#define NET_SERVER_WEB_SOCKET_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "net/server/http_server.h"
+
+#include <string>
+#include <vector>
+
+namespace net {
+
+class HttpServerRequestInfo;
+
+class WebSocket {
+ public:
+ static WebSocket* createWebSocket(Connection* connection,
eroman 2011/08/02 18:46:41 CreateWebSocket
+ const HttpServerRequestInfo& request,
+ size_t* pos);
+
+ enum ParseResult {
eroman 2011/08/02 18:46:41 Move this to the top of the public section.
+ FrameOK,
+ FrameIncomplete,
+ FrameError
eroman 2011/08/02 18:46:41 Chrome is using ALL_UPER_CASE_FOR_ENUMS
+ };
+
+ virtual void Accept(const HttpServerRequestInfo& request) = 0;
+ virtual ParseResult Read(std::string* message) = 0;
+ virtual void Send(const std::string& message) = 0;
eroman 2011/08/02 18:46:41 Please add a virtual destructor. I always recomme
+
+ protected:
+ WebSocket(Connection* connection);
eroman 2011/08/02 18:46:41 mark this as explicit.
+ Connection* connection_;
+};
+
+} // namespace net
+
+#endif // NET_SERVER_WEB_SOCKET_H_

Powered by Google App Engine
This is Rietveld 408576698