Issue 7482022: Update content_api to match naming conventions, style in ui_api.h

Issue 7482022: Update content_api to match naming conventions, style in ui_api.h (Closed)

Created:
9 years, 5 months ago by Dirk Pranke

Modified:
9 years, 4 months ago

Reviewers:
darin (slow to review), jam

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, ananta

Visibility:
Public.

Description

Update content_api to match naming conventions, style in ui_api.h, make work for linux build as well. R=jam@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97036

Patch Set 1 #

Patch Set 2 : update naming conventions from _API to _EXPORT, remove _TEST #

Patch Set 3 : rename content_api.h to content_export.h #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -26 lines)			Patch
M	content/common/content_api.h	View	1 2	1 chunk	+0 lines, -25 lines	0 comments	Download
A	content/common/content_export.h	View	1 2	1 chunk	+28 lines, -0 lines	2 comments	Download
M	content/content_common.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Hi John, I never actually landed this, so I've updated it to be CONTENT_EXPORT instead ...

9 years, 4 months ago (2011-08-12 23:08:06 UTC) #3

darin (slow to review)

Please rename the header file to content_export.h to match conventions elsewhere.

9 years, 4 months ago (2011-08-12 23:30:37 UTC) #4

Dirk Pranke

On 2011/08/12 23:30:37, darin wrote: > Please rename the header file to content_export.h to match ...

9 years, 4 months ago (2011-08-13 00:27:02 UTC) #5

Dirk Pranke

ping ... darin (or john), can you please take another look and approve the current ...

9 years, 4 months ago (2011-08-15 21:40:31 UTC) #6

darin (slow to review)

9 years, 4 months ago (2011-08-16 17:22:27 UTC) #7

LGTM

http://codereview.chromium.org/7482022/diff/8001/content/common/content_export.h
File content/common/content_export.h (right):

http://codereview.chromium.org/7482022/diff/8001/content/common/content_expor...
content/common/content_export.h:5: #ifndef CONTENT_COMMON_CONTENT_API_H_
nit: please fix the include guard

http://codereview.chromium.org/7482022/diff/8001/content/common/content_expor...
content/common/content_export.h:10: // can be exported to consumers.
nit: new line after this comment block, or just delete this comment block.

Expand Messages | Collapse Messages