Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6490)

Unified Diff: chrome/browser/resources/ntp4/most_visited_page.js

Issue 7481023: Adding notifications for new sync types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with trunk. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/new_tab.js ('k') | chrome/browser/resources/ntp4/new_tab.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/most_visited_page.js
diff --git a/chrome/browser/resources/ntp4/most_visited_page.js b/chrome/browser/resources/ntp4/most_visited_page.js
index eba402215281041f23ee24d38541ec4f4c9b87db..fa8e84e26749abb3a30cfc7871a6d27578ffc843 100644
--- a/chrome/browser/resources/ntp4/most_visited_page.js
+++ b/chrome/browser/resources/ntp4/most_visited_page.js
@@ -316,6 +316,11 @@ cr.define('ntp4', function() {
if (!this.data_) {
this.createTiles_();
this.data_ = data.slice(0, THUMBNAIL_COUNT);
+ // Display the sync notification when the page is first initialized - we
+ // don't want to display the notification multiple times, so we do this
+ // here instead of refreshData().
+ if (templateData.syncNotification)
+ this.showSyncNotification_();
} else {
this.data_ = refreshData(this.data_, data);
}
@@ -324,6 +329,24 @@ cr.define('ntp4', function() {
logEvent('mostVisited.layout: ' + (Date.now() - startTime));
},
+ /**
+ * Displays a sync-related notification on the NTP.
+ * @private
+ */
+ showSyncNotification_: function() {
+ var advancedOptionsLink = {
+ action: function() {
+ chrome.send('SyncTypeLinkClicked');
+ },
+ text: templateData.syncLinkText
+ };
+ ntp4.showNotification(templateData.syncNotification,
+ [advancedOptionsLink],
+ function() {
+ chrome.send('closeSyncNotification');
+ });
+ },
+
/** @inheritDoc */
shouldAcceptDrag: function(e) {
return false;
« no previous file with comments | « chrome/browser/resources/new_tab.js ('k') | chrome/browser/resources/ntp4/new_tab.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698