Adding notifications for new sync types.

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 109 matching lines @@
     themeChanged();
 
     dotList = getRequiredElement('dot-list');
     pageList = getRequiredElement('page-list');
     trash = getRequiredElement('trash');
     new ntp4.Trash(trash);
 
     shownPage = templateData['shown_page_type'];
     shownPageIndex = templateData['shown_page_index'];
 
-    document.querySelector('#notification button').onclick = function(e) {
-      hideNotification();
-    };
-
     // Request data on the apps so we can fill them in.
     // Note that this is kicked off asynchronously.  'getAppsCallback' will be
     // invoked at some point after this function returns.
     chrome.send('getApps');
 
     // Prevent touch events from triggering any sort of native scrolling
     document.addEventListener('touchmove', function(e) {
       e.preventDefault();
     }, true);
 
@@ skipping 443 matching lines @@
     */
   var notificationTimeout_ = 0;
 
   /**
    * Shows the notification bubble.
    * @param {string} text The notification message.
    * @param {Array.<{text: string, action: function()}>} links An array of
    *     records describing the links in the notification. Each record should
    *     have a 'text' attribute (the display string) and an 'action' attribute
    *     (a function to run when the link is activated).
+   * @param {Function} opt_close_handler The callback invoked if the user
+   *     manually dismisses the notification.
    */
-  function showNotification(text, links) {
+  function showNotification(text, links, opt_close_handler) {

[Evan Stade, 2011/08/02 22:18:37]

opt_closeHandler

[Andrew T Wilson (Slow), 2011/08/03 19:03:34]

Done.

     window.clearTimeout(notificationTimeout_);
     document.querySelector('#notification > span').textContent = text;
 
     var linksBin = $('notificationLinks');
     linksBin.textContent = '';
     for (var i = 0; i < links.length; i++) {
       var link = linksBin.ownerDocument.createElement('div');
       link.textContent = links[i].text;
       var action = links[i].action;
       link.onclick = function(e) {
         action();
         hideNotification();
       }
       link.setAttribute('role', 'button');
       link.setAttribute('tabindex', 0);
       link.className = "linkButton";
       linksBin.appendChild(link);
     }
 
+    document.querySelector('#notification button').onclick = function(e) {
+      if (opt_close_handler)
+        opt_close_handler();
+      hideNotification();
+    };
+
     $('notification').classList.remove('inactive');
     notificationTimeout_ = window.setTimeout(hideNotification, 10000);
   }
 
   /**
    * Hide the notification bubble.
    */
   function hideNotification() {
     $('notification').classList.add('inactive');
   }
@@ skipping 51 matching lines @@
 // TODO(estade): update the content handlers to use ntp namespace instead of
 // making these global.
 var assert = ntp4.assert;
 var getAppsCallback = ntp4.getAppsCallback;
 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
 var themeChanged = ntp4.themeChanged;
 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
 var setMostVisitedPages = ntp4.setMostVisitedPages;
 
 document.addEventListener('DOMContentLoaded', ntp4.initialize);