media/base/media_event_types.h - Issue 7480032: Plumb media data from renderers up to MediaInternals in the browser process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/media_event_types.h

Issue 7480032: Plumb media data from renderers up to MediaInternals in the browser process. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Much cleanup and making MediaLog thread safe. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // A list of media events. This file is included by media_log.h multiple times,
	jam 2011/07/29 16:08:55 given that there are 5 entries, and all you want i given that there are 5 entries, and all you want is an enum and a string, there's no need to have this multiple-include business. in cases like this we just have a function that has a switch around the enum, and the default has a NOTREACHED to catch the case when people add a new one. Scott Franklin 2011/07/29 22:30:25 Sure, I'll fill it in manually. It can always be s Show quoted text On 2011/07/29 16:08:55, John Abd-El-Malek wrote: > given that there are 5 entries, and all you want is an enum and a string, > there's no need to have this multiple-include business. in cases like this we > just have a function that has a switch around the enum, and the default has a > NOTREACHED to catch the case when people add a new one. Sure, I'll fill it in manually. It can always be split off easily if the number of events grows too large (I'm expecting only 20 at most) or appears in more places (probably unlikely). The NOTREACHED() below the switch instead of as a default seems to be better, as gcc throws an error if you fail to handle a case.
	6 // hence no header guards. DO NOT include elsewhere.

	7

	8 // A media player has been created or destroyed.

	9 // Params: none.

	10 EVENT(CREATED)

	11 EVENT(DESTROYED)

	12

	13 // A media player is loading a resource.

	14 // Params:

	15 // "url": <URL of the resource>

	16 EVENT(LOAD)

	17

	18 // A media player started playing.

	19 // Params: none.

	20 EVENT(PLAY)

	21

	22 // A media player paused playback.

	23 // Params: none.

	24 EVENT(PAUSE)

OLD	NEW

« ipc/ipc_message_utils.h ('K') | « ipc/ipc_message_utils.h ('k') | media/base/media_log.h » ('j') | media/base/media_log.h » ('J')