Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 7480028: Removal of Profile from content part 2. (Closed)

Created:
9 years, 5 months ago by Avi (use Gerrit)
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr.
Visibility:
Public.

Description

Removal of Profile from content part 2. BUG=76788 TEST=no change visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94332 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94347

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -70 lines) Patch
M chrome/browser/debugger/devtools_window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 7 chunks +20 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/spellcheck_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/spellcheck_message_filter.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 6 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/visitedlink/visitedlink_event_listener.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browsing_instance.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/debugger/devtools_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M content/common/content_notification_types.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
9 years, 5 months ago (2011-07-26 21:39:21 UTC) #1
jam
lgtm http://codereview.chromium.org/7480028/diff/1/chrome/browser/extensions/extension_event_router.cc File chrome/browser/extensions/extension_event_router.cc (right): http://codereview.chromium.org/7480028/diff/1/chrome/browser/extensions/extension_event_router.cc#newcode205 chrome/browser/extensions/extension_event_router.cc:205: listener->process->browser_context() != restrict_to_profile; will this automatically cast the ...
9 years, 5 months ago (2011-07-27 17:17:57 UTC) #2
Avi (use Gerrit)
On 2011/07/27 17:17:57, John Abd-El-Malek wrote: > will this automatically cast the Profile* to a ...
9 years, 5 months ago (2011-07-27 17:21:23 UTC) #3
Avi (use Gerrit)
9 years, 4 months ago (2011-07-27 20:21:55 UTC) #4
jam--

This failed when I landed it because six revs earlier another reference was
added that I didn't catch when I rebased. No code change except for
extensions/extension_permissions_api.cc which I added on as a patch too late.
Will reland.

Powered by Google App Engine
This is Rietveld 408576698