Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 7477056: Add base class for generators (Closed)

Created:
9 years, 4 months ago by noelallen1
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add base class for generators This CL is the first step towards alowing multiple generators with a single driver to simplify the use of the generator. It removes old built-in in idl_c_header.py, and replaces it with several golden files to verify output is unchanged. It renames the old 'version' option to 'release' to disambiguate between a RELEASE name such as M14, and an interface VERSION such as 1.0. Removes the 'M14' hack which as added to the source code to force release M14 to be generated. TEST= ./generator.py BUG= http://code.google.com/p/chromium/issues/detail?id=91607 R=sehr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97752

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -123 lines) Patch
A ppapi/generators/generator.py View 1 1 chunk +32 lines, -0 lines 0 comments Download
M ppapi/generators/idl_c_header.py View 1 2 5 chunks +44 lines, -117 lines 0 comments Download
M ppapi/generators/idl_c_proto.py View 1 4 chunks +4 lines, -5 lines 0 comments Download
A ppapi/generators/idl_generator.py View 1 2 1 chunk +187 lines, -0 lines 0 comments Download
M ppapi/generators/idl_namespace.py View 1 1 chunk +0 lines, -1 line 0 comments Download
A ppapi/generators/test_cgen/enum_typedef.h View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
A ppapi/generators/test_cgen/interface.h View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A ppapi/generators/test_cgen/stdint.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A ppapi/generators/test_cgen/stdint.idl View 1 1 chunk +51 lines, -0 lines 0 comments Download
A ppapi/generators/test_cgen/structs.h View 1 2 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
9 years, 4 months ago (2011-08-03 23:59:06 UTC) #1
sehr (please use chromium)
One question, one grammar nit. http://codereview.chromium.org/7477056/diff/1/ppapi/generators/idl_generator.py File ppapi/generators/idl_generator.py (right): http://codereview.chromium.org/7477056/diff/1/ppapi/generators/idl_generator.py#newcode27 ppapi/generators/idl_generator.py:27: # been enabled through ...
9 years, 4 months ago (2011-08-16 16:43:11 UTC) #2
noelallen1
9 years, 4 months ago (2011-08-19 00:27:28 UTC) #3
noelallen1
http://codereview.chromium.org/7477056/diff/1/ppapi/generators/idl_generator.py File ppapi/generators/idl_generator.py (right): http://codereview.chromium.org/7477056/diff/1/ppapi/generators/idl_generator.py#newcode27 ppapi/generators/idl_generator.py:27: # been enabled through command-line options. To a enable ...
9 years, 4 months ago (2011-08-19 17:07:29 UTC) #4
sehr (please use chromium)
9 years, 4 months ago (2011-08-22 21:43:48 UTC) #5
Ultra-nits.  LGTM otherwise.

http://codereview.chromium.org/7477056/diff/5001/ppapi/generators/test_cgen/e...
File ppapi/generators/test_cgen/enum_typedef.h (right):

http://codereview.chromium.org/7477056/diff/5001/ppapi/generators/test_cgen/e...
ppapi/generators/test_cgen/enum_typedef.h:17: * This file will test that the IDL
snippet matches the comment */
Comment style should have */ below.

http://codereview.chromium.org/7477056/diff/5001/ppapi/generators/test_cgen/i...
File ppapi/generators/test_cgen/interface.h (right):

http://codereview.chromium.org/7477056/diff/5001/ppapi/generators/test_cgen/i...
ppapi/generators/test_cgen/interface.h:18: * This file will test that the IDL
snippet matches the comment */
comment style.

http://codereview.chromium.org/7477056/diff/5001/ppapi/generators/test_cgen/s...
File ppapi/generators/test_cgen/structs.h (right):

http://codereview.chromium.org/7477056/diff/5001/ppapi/generators/test_cgen/s...
ppapi/generators/test_cgen/structs.h:17: * This file will test that the IDL
snippet matches the comment */
comment style.

Powered by Google App Engine
This is Rietveld 408576698