Change HttpAuthHandlerMock to accept and return more than one

Change HttpAuthHandlerMock to accept and return more than one http_auth_handler.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96481

[Ryan Hamilton, 2011-08-03 20:55:34]

Hi Chris,

Can you take a look at this CL?  It tweaks HttpAuthHandlerMock as we discussed
over email.  This is part of a larger CL, but I though it made sense to keep
these changes isolated.  What do you think?

Cheers,

Ryan

[cbentzel, 2011-08-03 21:22:09]

LGTM

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
File net/http/http_auth_handler_mock.cc (right):

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
net/http/http_auth_handler_mock.cc:160: scoped_ptr<HttpAuthHandler>
tmp_handler(handlers_[target][0]);
I'd add an alias to handlers_[target].get() here to make this less confusing. In
all cases we can go through the un-scoped vector.

[cbentzel, 2011-08-03 21:27:38]

Also - you may need to change the copyright's to 2011 in the files.

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
File net/http/http_auth_handler_mock.h (right):

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
net/http/http_auth_handler_mock.h:34: // CreateAuthHandler is called.
Can you change this comment?

[Ryan Hamilton, 2011-08-03 22:03:37]

I've also updated the copyright.

Thans for the LGTM!

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
File net/http/http_auth_handler_mock.cc (right):

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
net/http/http_auth_handler_mock.cc:160: scoped_ptr<HttpAuthHandler>
tmp_handler(handlers_[target][0]);
On 2011/08/03 21:22:10, cbentzel wrote:
> I'd add an alias to handlers_[target].get() here to make this less confusing.
In
> all cases we can go through the un-scoped vector. 

Done.

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
File net/http/http_auth_handler_mock.h (right):

http://codereview.chromium.org/7477055/diff/6001/net/http/http_auth_handler_m...
net/http/http_auth_handler_mock.h:34: // CreateAuthHandler is called.
On 2011/08/03 21:27:38, cbentzel wrote:
> Can you change this comment?

Done.

[cbentzel, 2011-08-11 21:28:52]

LGTM

[commit-bot: I haz the power, 2011-08-11 23:07:11]

Change committed as 96481