src/runtime.cc - Issue 7477045: Tentative implementation of string slices (hidden under the flag --string-slices).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 7477045: Tentative implementation of string slices (hidden under the flag --string-slices). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Implemented some changes suggested by Anton. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index e193dfc97710ba18b06d19282b011f9f6f87b372..9bbe79a7c19255f5250b7d56f6fb4cc790a24a4a 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -3581,7 +3581,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_RegExpExecMultiple) {

HandleScope handles(isolate);

CONVERT_ARG_CHECKED(String, subject, 1);

- if (!subject->IsFlat()) { FlattenString(subject); }

+ if (!subject->IsFlatAndTruncated()) FlattenOrTruncateString(subject);

CONVERT_ARG_CHECKED(JSRegExp, regexp, 0);

CONVERT_ARG_CHECKED(JSArray, last_match_info, 2);

CONVERT_ARG_CHECKED(JSArray, result_array, 3);

« src/objects.h ('K') | « src/regexp-macro-assembler.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »