Add additional check for required passphrase in SetupSync

Add additional check for required passphrase in SetupSync

The sync integration tests use a method called SetupSync to initialize a
sync client. The step that performs an initial sync can sometimes
remain incomplete due to a required passphrase.

r93873 relocated the check for SET_PASSPHRASE_FAILED in SetupSync. It
turns out that this check needs to be made before and after initial
sync, since SET_PASSPHRASE_FAILED can be triggered in a couple of
places.

This patch adds a check at the original place, and should fix the flaky
test SetPassphraseAndThenSetupSync.

TBR=zea@chromium.org
BUG=90371, 90397
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94076

[Raghu Simha, 2011-07-26 09:54:14]

Nicolas, this should fix the remaining flakiness you reported yesterday.

I'll likely land this before you get to look at this, since I'm 12.5 hrs ahead
of Pacific time. I'll make sure the bots are satisfied first. Feel free to
revert if you think the fix lies inside the syncer thread (although I belive
that's pretty unlikely).

[Raghu Simha, 2011-07-26 10:23:48]

Landing this change after testing the fix on the trybots and locally with
--gtest_repeat=20.