Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 7475002: Ensure that the length property of bound functions are actual unique (Closed)

Created:
9 years, 4 months ago by Rico
Modified:
9 years, 4 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Ensure that the length property of bound functions are actual unique for the individually bound functions. Our existing code will generate a new function on every call to bind, but it will use the same shared function. When setting the lenght this will be set on the shared function, i.e., the length of all bound functions will be that of the last bound function. Committed: http://code.google.com/p/v8/source/detail?r=8816

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-1419.js View 1 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 4 months ago (2011-08-03 11:27:21 UTC) #1
Erik Corry
9 years, 4 months ago (2011-08-03 11:35:31 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698