[Sync] Prevent switching back to "Sync Everything" view if passphrase needed.

chrome/browser/resources/sync_setup_overlay.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
 
   // Variable to track if a captcha challenge was issued. If this gets set to
   // true, it stays that way until we are told about successful login from
   // the browser.  This means subsequent errors (like invalid password) are
@@ skipping 226 matching lines @@
         customPassphrase = $('custom-passphrase').value;
         usePassphrase = true;
       } else {
         // The user is not setting a custom passphrase.
         usePassphrase = false;
       }
 
       // Don't allow the user to tweak the settings once we send the
       // configuration to the backend.
       this.setInputElementsDisabledState_(true);
+      var self = this;
+      this.animateDisableLink_($('use-default-link'), true, function() {

[James Hawkins, 2011/07/31 23:50:53]

No need to specify this callback function since you're passing in true for
|disabled|.

[Nicolas Zea, 2011/08/01 17:09:59]

Done.

+        self.showSyncEverythingPage_();
+      });
 
       // These values need to be kept in sync with where they are read in
       // SyncSetupFlow::GetDataTypeChoiceData().
       var result = JSON.stringify({
           "keepEverythingSynced": syncAll,
           "syncBookmarks": syncAll || $('bookmarks-checkbox').checked,
           "syncPreferences": syncAll || $('preferences-checkbox').checked,
           "syncThemes": syncAll || $('themes-checkbox').checked,
           "syncPasswords": syncAll || $('passwords-checkbox').checked,
           "syncAutofill": syncAll || $('autofill-checkbox').checked,
@@ skipping 20 matching lines @@
       var configureElements =
           $('customize-sync-preferences').querySelectorAll('input');
       for (var i = 0; i < configureElements.length; i++)
         configureElements[i].disabled = disabled;
       $('sync-select-datatypes').disabled = disabled;
 
       var self = this;
       this.animateDisableLink_($('customize-link'), disabled, function() {
         self.showCustomizePage_(null, true);
       });
-
-      this.animateDisableLink_($('use-default-link'), disabled, function() {
-        self.showSyncEverythingPage_();
-      });
     },
 
     /**
      * Animate a link being enabled/disabled. The link is hidden by animating
      * its opacity, but to ensure the user doesn't click it during that time,
      * its onclick handler is changed to null as well.
      * @param elt The anchor element to enable/disable.
      * @param disabled True if the link should be disabled.
      * @param enabledFunction The onclick handler when the link is enabled.
      * @private
@@ skipping 158 matching lines @@
 
     /**
      * Reveals the UI for entering a custom passphrase during initial setup.
      * This happens if the user has previously enabled a custom passphrase on a
      * different machine.
      * @param {Array} args The args that contain the passphrase UI
      *     configuration.
      * @private
      */
     showPassphraseContainer_: function(args) {
+      // Once we require a passphrase, we prevent the user from returning to
+      // the Sync Everything pane.
+      $('use-default-link').hidden = true;
       $('sync-custom-passphrase-container').hidden = true;
       $('sync-existing-passphrase-container').hidden = false;
 
       if (args["passphrase_creation_rejected"])
         $('passphrase-rejected-body').hidden = false;
       else
         $('normal-body').hidden = false;
 
       if (args["passphrase_setting_rejected"])
         $('incorrect-passphrase').hidden = false;
@@ skipping 14 matching lines @@
       // likely he intends to change the data types. Select the
       // 'Choose data types' option in this case.
       var index = syncEverything ? 0 : 1;
       document.getElementById('sync-select-datatypes').selectedIndex = index;
       this.setDataTypeCheckboxesEnabled_(!syncEverything);
 
       // The passphrase input may need to take over focus from the OK button, so
       // set focus before that logic.
       $('choose-datatypes-ok').focus();
 
-      if (args && args['show_passphrase'])
+      if (args && args['show_passphrase']) {
         this.showPassphraseContainer_(args);
+      } else {
+        // We only show the "Use Default" link if we're not prompting for an
+        // existing passphrase.
+        var self = this;
+        this.animateDisableLink_($('use-default-link'), false, function() {
+          self.showSyncEverythingPage_();
+        });
+      }
     },
 
     attach_: function() {
       chrome.send('SyncSetupAttachHandler');
     },
 
     showSyncSetupPage_: function(page, args) {
       if (page == 'settingUp') {
         this.setThrobbersVisible_(true);
         return;
@@ skipping 287 matching lines @@
 
   SyncSetupOverlay.showStopSyncingUI = function() {
     SyncSetupOverlay.getInstance().showStopSyncingUI_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });