Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 7474013: Extract the CSS for the net_internals EventsView and LogsView to separate files. Also rename thes... (Closed)

Created:
9 years, 4 months ago by eroman
Modified:
9 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, arv (Not doing code reviews), eroman
Visibility:
Public.

Description

Extract the CSS for the net_internals EventsView and LogsView to separate files. Also rename these properties to be lowercase-hyphenated, and prefixed by the view name. BUG=90857 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -652 lines) Patch
M chrome/browser/resources/net_internals/category_tabs.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/net_internals/events_view.css View 3 chunks +25 lines, -193 lines 0 comments Download
M chrome/browser/resources/net_internals/events_view.html View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/net_internals/events_view.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/resources/net_internals/logs_view.css View 2 chunks +9 lines, -252 lines 0 comments Download
M chrome/browser/resources/net_internals/logs_view.html View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/net_internals/logs_view.js View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/net_internals/main.css View 3 chunks +4 lines, -175 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
(i'll transition everything over to new naming gradually)
9 years, 4 months ago (2011-07-29 04:17:06 UTC) #1
mmenke
9 years, 4 months ago (2011-07-29 14:37:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698