Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 7474010: mac: Components build for base, easy part (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

mac: Components build for base, easy part BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94636

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -76 lines) Patch
M base/file_version_info.h View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/foundation_util.h View 1 8 chunks +30 lines, -26 lines 0 comments Download
M base/mac/mac_util.h View 1 5 chunks +28 lines, -26 lines 0 comments Download
M base/mac/objc_property_releaser.h View 2 chunks +3 lines, -1 line 0 comments Download
M base/mac/os_crash_dumps.h View 2 chunks +3 lines, -1 line 0 comments Download
M base/mac/scoped_nsautorelease_pool.h View 2 chunks +2 lines, -1 line 0 comments Download
M base/mac/scoped_nsexception_enabler.h View 3 chunks +4 lines, -3 lines 0 comments Download
M base/mach_ipc_mac.h View 5 chunks +5 lines, -4 lines 0 comments Download
M base/process_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_string_conversions.h View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
9 years, 4 months ago (2011-07-29 01:35:09 UTC) #1
Mark Mentovai
Mmmkay. LGTM.
9 years, 4 months ago (2011-07-29 03:40:15 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-07-29 04:43:17 UTC) #3
Change committed as 94636

Powered by Google App Engine
This is Rietveld 408576698