PPB_VideoDecoder_Dev::Initialize is now synchronous!

ppapi/examples/gles2/gles2.cc

Index: ppapi/examples/gles2/gles2.cc
diff --git a/ppapi/examples/gles2/gles2.cc b/ppapi/examples/gles2/gles2.cc
index e46f02dca3a84315e9a9bac3ddcf61d06e779ffc..e9173749f63b0902daf32f1e186e0b7f25b4fb37 100644
--- a/ppapi/examples/gles2/gles2.cc
+++ b/ppapi/examples/gles2/gles2.cc
@@ -213,16 +213,12 @@ void GLES2DemoInstance::DidChangeView(
 }
 
 void GLES2DemoInstance::InitializeDecoder() {
-  assert(!video_decoder_);
-  video_decoder_ = new pp::VideoDecoder_Dev(*this);
-
   PP_VideoConfigElement configs = PP_VIDEOATTR_DICTIONARY_TERMINATOR;
-  pp::CompletionCallback cb =
-      callback_factory_.NewCallback(&GLES2DemoInstance::DecoderInitDone);
-  video_decoder_->Initialize(&configs, *context_, cb);
-}
 
-void GLES2DemoInstance::DecoderInitDone(int32_t result) {
+  assert(!video_decoder_);
+  video_decoder_ = new pp::VideoDecoder_Dev(*this, *context_, &configs);
+  assert(!video_decoder_->is_null());

[vrk (LEFT CHROMIUM), 2011/07/29 18:11:02]

nit: is there any way for this to fail?

[Ami GONE FROM CHROMIUM, 2011/07/29 18:20:41]

In this plugin, not really, b/c we already assert that *context_ is valid
earlier, but this is a sample plugin so I think it's useful to be as explicit as
possible about the things that can/ought to be checked.

+
   DecodeNextNALUs();
 }