PPB_VideoDecoder_Dev::Initialize is now synchronous!

ppapi/c/dev/ppb_video_decoder_dev.h

 /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_
 #define PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_
 
 #include "ppapi/c/dev/pp_video_dev.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_var.h"
 
-#define PPB_VIDEODECODER_DEV_INTERFACE_0_14 "PPB_VideoDecoder(Dev);0.14"
-#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_14
+#define PPB_VIDEODECODER_DEV_INTERFACE_0_15 "PPB_VideoDecoder(Dev);0.15"
+#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_15
 
 // Video decoder interface.
 //
 // Typical usage:
 // - Use Create() to get a new PPB_VideoDecoder_Dev resource.
 // - Call Initialize() to create the underlying resources in the GPU process and
 //   configure the decoder there.
 // - Call Decode() to decode some video data.
 // - Receive ProvidePictureBuffers callback
 //   - Supply the decoder with textures using AssignPictureBuffers.
@@ skipping 26 matching lines @@
   // Returns true if is a video decoder, false otherwise.
   PP_Bool (*IsVideoDecoder)(PP_Resource resource);
 
   // Initializes the video decoder with requested configuration.
   //
   // Parameters:
   //   |video_decoder| is the previously created handle to the decoder resource.
   //   |context| the GL context in which decoding will happen. This should be a
   //   resource of type PPB_Context3D_Dev.
   //   |decoder_config| the configuration to use to initialize the decoder.
-  //   |callback| called after initialization is complete.
   //
   // Returns an error code from pp_errors.h.
   int32_t (*Initialize)(PP_Resource video_decoder,
                         PP_Resource context,
-                        const PP_VideoConfigElement* decoder_config,
-                        struct PP_CompletionCallback callback);
+                        const PP_VideoConfigElement* decoder_config);

[piman, 2011/07/28 23:40:59]

Does it make sense to fold this into Create ?

[Ami GONE FROM CHROMIUM, 2011/07/29 05:58:48]

Hell yes it does!
Done.

 
   // Dispatches bitstream buffer to the decoder.
   //
   // Parameters:
   //   |video_decoder| is the previously created handle to the decoder resource.
   //   |bitstream_buffer| is the bitstream buffer that contains the input data.
   //   |callback| will be called when |bitstream_buffer| has been processed by
   //   the decoder.
   //
   // Returns an error code from pp_errors.h.
@@ skipping 60 matching lines @@
   // may be freed asynchronously, after this method returns no more callbacks
   // will be made on the client.  Any resources held by the client at that point
   // may be freed.
   //
   // Parameters:
   //   |video_decoder| is the previously created handle to the decoder resource.
   void (*Destroy)(PP_Resource video_decoder);
 };
 
 #endif  /* PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_ */