Cleanup for r93201.

Cleanup for r93201.

The initializer for watcher_ in the FileDescriptorWatcher constructor
was deleted accidentally.

USE_SYSTEM_LIBEVENT is defined by the build system, so we don't need
to include "build/build_config.h".

R=willchan@chromium.org
BUG=88134
TEST=MessagePumpLibeventTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93460

[willchan no longer on Chromium, 2011-07-21 06:59:33]

Oh, thanks! LGTM

On Thu, Jul 21, 2011 at 1:33 AM,  <wtc@chromium.org> wrote:
> Reviewers: willchan,
>
> Description:
> Cleanup for r93201.
>
> The initializer for watcher_ in the FileDescriptorWatcher constructor
> was deleted accidentally.
>
> USE_SYSTEM_LIBEVENT is defined by the build system, so we don't need
> to include "build/build_config.h".
>
> R=willchan@chromium.org
> BUG=88134
> TEST=MessagePumpLibeventTest.*
>
> Please review this at http://codereview.chromium.org/7473017/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/message_pump_libevent.cc
>  M     base/message_pump_libevent_unittest.cc
>
>
> Index: base/message_pump_libevent.cc
> ===================================================================
> --- base/message_pump_libevent.cc       (revision 93224)
> +++ base/message_pump_libevent.cc       (working copy)
> @@ -54,6 +54,7 @@
>     : is_persistent_(false),
>       event_(NULL),
>       pump_(NULL),
> +      watcher_(NULL),
>       ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
>  }
>
> @@ -350,7 +351,8 @@
>   if (flags & EV_WRITE) {
>     controller->OnFileCanWriteWithoutBlocking(fd, pump);
>   }
> -  // Check |controller| in case it's been deleted in this callback.
> +  // Check |controller| in case it's been deleted in
> +  // controller->OnFileCanWriteWithoutBlocking().
>   if (controller.get() && flags & EV_READ) {
>     controller->OnFileCanReadWithoutBlocking(fd, pump);
>   }
> Index: base/message_pump_libevent_unittest.cc
> ===================================================================
> --- base/message_pump_libevent_unittest.cc      (revision 93224)
> +++ base/message_pump_libevent_unittest.cc      (working copy)
> @@ -8,7 +8,6 @@
>
>  #include "base/message_loop.h"
>  #include "base/threading/thread.h"
> -#include "build/build_config.h"
>  #include "testing/gtest/include/gtest/gtest.h"
>
>  #if defined(USE_SYSTEM_LIBEVENT)
>
>
>

[commit-bot: I haz the power, 2011-07-21 20:16:12]

Change committed as 93460