Revert r92977 partially to fix a certificate verification regression

Revert r92977 partially to fix a certificate verification regression
on Windows.

We still need X509Certificate::cert_store().  Make it a leaky lazy
instance.

R=rsleevi@chromium.org,rvargas@chromium.org
BUG=89899, 49377
TEST=Visit https://bugs.webkit.org/show_bug.cgi?id=64580 on Windows.
Should not get the untrusted certificate error.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93338

[wtc, 2011-07-20 19:25:04]

http://codereview.chromium.org/7473009/diff/1/net/base/x509_certificate_win.cc
File net/base/x509_certificate_win.cc (right):

http://codereview.chromium.org/7473009/diff/1/net/base/x509_certificate_win.c...
net/base/x509_certificate_win.cc:670: g_cert_store(base::LINKER_INITIALIZED);
rsleevi: I made this lazy instance leaky based on your
suggestion in the code review comment of
http://codereview.chromium.org/2944008.

[rvargas (doing something else), 2011-07-20 21:34:06]

LGTM

http://codereview.chromium.org/7473009/diff/1/net/base/x509_certificate.cc
File net/base/x509_certificate.cc (right):

http://codereview.chromium.org/7473009/diff/1/net/base/x509_certificate.cc#ne...
net/base/x509_certificate.cc:252: static X509Certificate::OSCertHandle
CreateOSCert(base::StringPiece der_cert) {
I know this is not really part of this change, but this function should move to
the unnamed namespace above instead of sitting in between methods of a class.

[Ryan Sleevi, 2011-07-20 22:07:10]

LGTM.

My test list was the Alexa Top 25 US (those which had encrypted pages, at
least), the original moversguide site (which has since changed certificates),
and the top 5 US banks from http://www.infoplease.com/toptens/usbanks.html

Had I made it to #6, Morgan Stanley ( https://www.morganstanley.com ), I would
have seen the error, as there is no AIA information present in it (Akamai
Intermediate)

I'd still like to request review for  http://codereview.chromium.org/7324039/ ,
which also solves this problem - and the thread-safety issue where an
X509Certificate created/deleted while a worker thread is in Verify can result in
 certs being skipped. 


It's not clear why X509CertificateTest.IntermediateCARequireExplicitPolicy
didn't catch this - the dod_ca_17_cert.der should have been missing, and it's
not shipped by default in Windows, and the bots themselves are (AFAIK) segmented
from the Internet.

[commit-bot: I haz the power, 2011-07-21 04:48:19]

Change committed as 93338