Issue 7472040: Merge 91337 - [chromium] Media player controls do not fade out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7472040: Merge 91337 - [chromium] Media player controls do not fade out. (Closed)

Created:
9 years, 5 months ago by sjl

Modified:
9 years, 5 months ago

Reviewers:
sjl

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/

Visibility:
Public.

Description

Merge 91337 - [chromium] Media player controls do not fade out. https://bugs.webkit.org/show_bug.cgi?id=64837 Media controls were not fading out when the mouse leaves the video due to underlying changes in webkit media controls. Fix was to copy missing code from MediaControlRootElement to MediaControlRootElementChromium. Reviewed by Dimitri Glazkov. * html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium): (WebCore::MediaControlRootElementChromium::playbackProgressed): (WebCore::MediaControlRootElementChromium::containsRelatedTarget): (WebCore::MediaControlRootElementChromium::defaultEventHandler): * html/shadow/MediaControlRootElementChromium.h: TBR=sjl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91477

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+833 lines, -4 lines)			Patch
M	Source/WebCore/ChangeLog	View	1 chunk	+797 lines, -4 lines	0 comments	Download
M	Source/WebCore/html/shadow/MediaControlRootElementChromium.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	View	4 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages