Issue 7472029: Introduce a poor man's version of STL's bitset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7472029: Introduce a poor man's version of STL's bitset. (Closed)

Created:
9 years, 5 months ago by Sven Panne

Modified:
9 years, 5 months ago

Reviewers:
danno, Mads Ager (chromium), Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Introduce a poor man's version of STL's bitset. Used in a separate upcoming patch... Committed: http://code.google.com/p/v8/source/detail?r=8715

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/utils.h	View		2 chunks	+25 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

A small & independent patch, just to keep the upcoming ToBoolean patch manageable.

9 years, 5 months ago (2011-07-21 09:10:31 UTC) #1

Vitaly Repeshko

http://codereview.chromium.org/7472029/diff/1/src/utils.h File src/utils.h (right): http://codereview.chromium.org/7472029/diff/1/src/utils.h#newcode33 src/utils.h:33: #include <climits> We include old school standard library headers ...

9 years, 5 months ago (2011-07-21 12:56:18 UTC) #3

Sven Panne

9 years, 5 months ago (2011-07-21 13:07:13 UTC) #4

http://codereview.chromium.org/7472029/diff/1/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/7472029/diff/1/src/utils.h#newcode33
src/utils.h:33: #include <climits>
On 2011/07/21 12:56:18, Vitaly Repeshko wrote:
> We include old school standard library headers without the "c" prefix (and the
implied std:: namespace).

That's not completely true, cstdio and cstdarg are already used.

> Use <limits.h> to be consistent.

To be consistent with the language used (C++), climits looks "more correct"
IMHO. ;-)

Expand Messages | Collapse Messages