Issue 7472002: Disallow gpu access if preliminary gpu info collection fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7472002: Disallow gpu access if preliminary gpu info collection fails. (Closed)

Created:
9 years, 5 months ago by Zhenyao Mo

Modified:
9 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit), piman

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disallow gpu access if preliminary gpu info collection fails. It's likely something seriously wrong with the graphics driver if preliminary gpu info collection fails. BUG=89358 TEST=bots green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93236

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	content/browser/gpu/gpu_data_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/gpu/gpu_data_manager.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

piman

That breaks gpu when running chrome 32 bits on a 64 bit arch. Probably because ...

9 years, 5 months ago (2011-07-22 02:32:20 UTC) #3

piman

On Thu, Jul 21, 2011 at 7:32 PM, <piman@chromium.org> wrote: > That breaks gpu when ...

9 years, 5 months ago (2011-07-22 16:26:35 UTC) #4

Ken Russell (switch to Gerrit)

9 years, 5 months ago (2011-07-22 17:50:58 UTC) #5

On 2011/07/22 16:26:35, piman wrote:
> On Thu, Jul 21, 2011 at 7:32 PM, <mailto:piman@chromium.org> wrote:
> 
> > That breaks gpu when running chrome 32 bits on a 64 bit arch. Probably
> > because
> > there is no libpci.so available.
> >
> 
> It also breaks ARM (no pci).
> 
> 
> >
> >
>
http://codereview.chromium.**org/7472002/%3Chttp://codereview.chromium.org/74...>
> >

This was rolled out in http://codereview.chromium.org/7495005 . There were more
unexpected problems than just the unavailability of the PCI library.

We should talk offline about how the GPU detection can be implemented on ARM.

Expand Messages | Collapse Messages