Issue 7471034: Fix deopts caused by misplaced COW checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7471034: Fix deopts caused by misplaced COW checks. (Closed)

Created:
9 years, 5 months ago by Jakob Kummerow

Modified:
9 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix deopts caused by misplaced COW checks. TEST=Performance of pixel-array-blur back to normal. Committed: http://code.google.com/p/v8/source/detail?r=8709

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	src/hydrogen.cc	View		2 chunks	+3 lines, -2 lines	2 comments	Download
	M	src/hydrogen-instructions.h	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM if you make the gating check for fast elements the same in the polymorphic ...

9 years, 5 months ago (2011-07-21 11:44:02 UTC) #2

Jakob Kummerow

9 years, 5 months ago (2011-07-21 12:01:32 UTC) #3

Thanks, landing.

http://codereview.chromium.org/7471034/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7471034/diff/1/src/hydrogen.cc#newcode4025
src/hydrogen.cc:4025: if (is_store && !fast_double_elements) {
On 2011/07/21 11:44:02, danno wrote:
> Should also be map->has_fast_elements()

Except that we don't have an object called |map| at this point. I've changed it
to "elements_kind == JSObject::FAST_ELEMENTS" instead.

Expand Messages | Collapse Messages