Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: ppapi/api/ppp_instance.idl

Issue 7471006: Revert 93223 - Reland http://codereview.chromium.org/7452002/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/c/pp_input_event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/api/ppp_instance.idl
===================================================================
--- ppapi/api/ppp_instance.idl (revision 93228)
+++ ppapi/api/ppp_instance.idl (working copy)
@@ -9,7 +9,7 @@
*/
label Chrome {
- M14 = 1.0
+ M14 = 0.5
};
/**
@@ -161,13 +161,11 @@
* An instance's default condition is that it will not have focus.
*
* <strong>Note:</strong>Clicks on instances will give focus only if you
- * handle the click event. Return <code>true</code> from
- * <code>HandleInputEvent</code> in <code>PPP_InputEvent</code> (or use
- * unfiltered events) to signal that the click event was handled. Otherwise,
- * the browser will bubble the event and give focus to the element on the page
- * that actually did end up consuming it. If you're not getting focus, check
- * to make sure you're returning true from the mouse click in
- * <code>HandleInputEvent</code>.
+ * handle the click event. Return <code>true</code> from HandleInputEvent to
+ * signal that the click event was handled. Otherwise the browser will bubble
+ * the event and give focus to the element on the page that actually did end
+ * up consuming it. If you're not getting focus, check to make sure you're
+ * returning true from the mouse click in <code>HandleInputEvent</code>.
*
* @param[in] instance A <code>PP_Instance</code> indentifying the instance
* receiving the input event.
@@ -181,6 +179,37 @@
[in] PP_Bool has_focus);
/**
+ * HandleInputEvent() handles input events, such as keyboard events. This
+ * function returns <code>PP_TRUE</code> if the event was handled or
+ * <code>PP_FALSE</code> if it was not.
+ *
+ * If the event was handled, it will not be forwarded to the web page or
+ * browser. If it was not handled, it will bubble according to the normal
+ * rules. So it is important that a module respond accurately with whether
+ * event propagation should continue.
+ *
+ * Event propagation also controls focus. If you handle an event like a mouse
+ * event, typically the instance will be given focus. Returning false means
+ * that the click will be given to a lower part of the page and your module
+ * will not receive focus. This allows an instance to be partially
+ * transparent, where clicks on the transparent areas will behave like clicks
+ * to the underlying page.
+ *
+ * @param[in] instance A <code>PP_Instance</code> indentifying one instance
+ * of a module.
+ *
+ * @param[in] event The input event.
+ *
+ * @return <code>PP_TRUE</code> if <code>event</code> was handled,
+ * <code>PP_FALSE</code> otherwise.
+ */
+ PP_Bool HandleInputEvent(
+ /* A PP_Instance indentifying one instance of a module. */
+ [in] PP_Instance instance,
+ /* The event. */
+ [in] PP_InputEvent event);
+
+ /**
* HandleDocumentLoad() is called after initialize for a full-frame
* module that was instantiated based on the MIME type of a DOMWindow
* navigation. This situation only applies to modules that are pre-registered
« no previous file with comments | « no previous file | ppapi/c/pp_input_event.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698