Unify the version string to be displayed on "About Chromium" dialog. (4/6)

Unify the version string to be displayed on "About Chromium" dialog. (4/6)

- Update version.bat to use lastchange.py.

FYI: We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the fourth step of them:

(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan)
(5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark)
(6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark)

BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Windows)" on Windows.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94409

[haraken1, 2011-07-27 14:11:15]

evan: would you please take a look at it?
tony, mark: FYI

[Evan Martin, 2011-07-27 18:16:26]

+maruel, rahulk, pamg.

I don't really know this file, so I added reviewers who have made changes to it
in the past.

[M-A Ruel, 2011-07-27 18:26:55]

Ugh, I didn't know we still had a .rules files. It wouldn't be compatible with
VS2010 anyway, Jean-Luc, should we kill this file while at it?

[Evan Martin, 2011-07-27 18:33:45]

Poor haraken has been working on this change for quite a while, so if
you think this modification is correct let's land this and then kill
the file afterwards.  :)

On Wed, Jul 27, 2011 at 11:26 AM,  <maruel@chromium.org> wrote:
> Ugh, I didn't know we still had a .rules files. It wouldn't be compatible
> with
> VS2010 anyway, Jean-Luc, should we kill this file while at it?
>
> http://codereview.chromium.org/7470041/
>

[Mark Mentovai, 2011-07-27 19:05:01]

I’d give LGTM to this now and save the unrelated bit for the future, but since
M-A raised the issue, please wait for his explicit approval.

This constitutes my review. If M-A says you’re good, you’re good.

[M-A Ruel, 2011-07-27 19:11:36]

On 2011/07/27 18:33:45, Evan Martin wrote:
> Poor haraken has been working on this change for quite a while, so if
> you think this modification is correct let's land this and then kill
> the file afterwards.  :)

So, version.rules is referenced by chrome/installer/setup/setup.vcproj but I
didn't find where setup.vcproj is referenced (?)

It's a matter of putting the relevant 'rule' command in the relevant .gyp file,
once we can figure out from which .gyp file it is referenced.

Carlos would know more. I won't block this change though, lgtm.

http://codereview.chromium.org/7470041/diff/1/chrome/tools/build/win/version.bat
File chrome/tools/build/win/version.bat (right):

http://codereview.chromium.org/7470041/diff/1/chrome/tools/build/win/version....
chrome/tools/build/win/version.bat:47: python %LastChangeDir%\lastchange.py |
sed "s/\(.*\)/set \1/" >> %VarsBat%
is sed in path? It'd be nice to convert everything to python, in a follow up
patch.

[Mark Mentovai, 2011-07-27 19:14:03]

http://codereview.chromium.org/7470041/diff/1/chrome/tools/build/win/version.bat
File chrome/tools/build/win/version.bat (right):

http://codereview.chromium.org/7470041/diff/1/chrome/tools/build/win/version....
chrome/tools/build/win/version.bat:47: python %LastChangeDir%\lastchange.py |
sed "s/\(.*\)/set \1/" >> %VarsBat%
Marc-Antoine Ruel wrote:
> is sed in path?

This script already pipes things to sed, so I think we have to assume so.

[commit-bot: I haz the power, 2011-07-28 01:32:51]

Change committed as 94409