Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: webkit/fileapi/overlay_file_util.h

Issue 7470037: [Refactor] to rename and re-layer the file_util stack layers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Reflected the comments and rebased. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/fileapi/obfuscated_file_util_unittest.cc ('k') | webkit/fileapi/overlay_file_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_FILE_UTIL_H_ 5 #ifndef WEBKIT_FILEAPI_OVERLAY_FILE_UTIL_H_
6 #define WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_FILE_UTIL_H_ 6 #define WEBKIT_FILEAPI_OVERLAY_FILE_UTIL_H_
7 7
8 #include <vector>
9
10 #include "base/callback.h"
11 #include "base/file_path.h" 8 #include "base/file_path.h"
12 #include "base/file_util.h"
13 #include "base/file_util_proxy.h" 9 #include "base/file_util_proxy.h"
14 #include "base/logging.h"
15 #include "base/memory/scoped_ptr.h"
16 #include "base/platform_file.h" 10 #include "base/platform_file.h"
17 #include "webkit/fileapi/file_system_file_util.h" 11 #include "webkit/fileapi/fileapi_file_util.h"
18 #include "webkit/fileapi/file_system_types.h"
19 12
20 namespace base { 13 namespace base {
21 struct PlatformFileInfo;
22 class MessageLoopProxy;
23 class Time; 14 class Time;
24 } 15 }
25 16
26 class GURL;
27
28 namespace fileapi { 17 namespace fileapi {
29 18
30 using base::PlatformFile; 19 using base::PlatformFile;
31 using base::PlatformFileError; 20 using base::PlatformFileError;
32
33 class FileSystemOperationContext; 21 class FileSystemOperationContext;
34 22
35 // An instance of this class is created and owned by *MountPointProvider. 23 class OverlayFileUtil : public FileApiFileUtil {
kinuko 2011/08/04 05:56:28 I'm feeling that probably we could combine this wi
Dai Mikurube (NOT FULLTIME) 2011/08/08 02:34:06 IMHO, combining makes NativeFileUtil to have an in
36 class LocalFileSystemFileUtil : public FileSystemFileUtil {
37 public: 24 public:
38 // |underlying_file_util| is owned by the instance. It will be deleted by 25 explicit OverlayFileUtil(FileApiFileUtil* underlying_file_util);
39 // the owner instance. For example, it can be instanciated as follows: 26 virtual ~OverlayFileUtil();
40 // FileSystemFileUtil* file_system_file_util =
41 // new LocalFileSystemFileUtil(new FileSystemFileUtil());
42 explicit LocalFileSystemFileUtil(FileSystemFileUtil* underlying_file_util);
43 virtual ~LocalFileSystemFileUtil();
44 27
45 virtual PlatformFileError CreateOrOpen( 28 virtual PlatformFileError CreateOrOpen(
46 FileSystemOperationContext* context, 29 FileSystemOperationContext* context,
47 const FilePath& file_path, 30 const FilePath& file_path,
48 int file_flags, 31 int file_flags,
49 PlatformFile* file_handle, 32 PlatformFile* file_handle,
50 bool* created); 33 bool* created);
51 34
35 virtual PlatformFileError Close(
36 FileSystemOperationContext* context,
37 PlatformFile);
38
52 virtual PlatformFileError EnsureFileExists( 39 virtual PlatformFileError EnsureFileExists(
53 FileSystemOperationContext* context, 40 FileSystemOperationContext* context,
54 const FilePath& file_path, bool* created); 41 const FilePath& file_path, bool* created);
55 42
56 virtual PlatformFileError GetLocalFilePath( 43 virtual PlatformFileError GetLocalFilePath(
57 FileSystemOperationContext* context, 44 FileSystemOperationContext* context,
58 const FilePath& virtual_file, 45 const FilePath& virtual_path,
59 FilePath* local_path); 46 FilePath* local_path);
60 47
61 virtual PlatformFileError GetFileInfo( 48 virtual PlatformFileError GetFileInfo(
62 FileSystemOperationContext* context, 49 FileSystemOperationContext* context,
63 const FilePath& file, 50 const FilePath& file_,
64 base::PlatformFileInfo* file_info, 51 base::PlatformFileInfo* file_info,
65 FilePath* platform_file); 52 FilePath* platform_path);
66 53
67 virtual PlatformFileError ReadDirectory( 54 virtual PlatformFileError ReadDirectory(
68 FileSystemOperationContext* context, 55 FileSystemOperationContext* context,
69 const FilePath& file_path, 56 const FilePath& file_path,
70 std::vector<base::FileUtilProxy::Entry>* entries); 57 std::vector<base::FileUtilProxy::Entry>* entries);
71 58
72 virtual PlatformFileError CreateDirectory( 59 virtual PlatformFileError CreateDirectory(
73 FileSystemOperationContext* context, 60 FileSystemOperationContext* context,
74 const FilePath& file_path, 61 const FilePath& file_path,
75 bool exclusive, 62 bool exclusive,
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 const FilePath& file_path); 101 const FilePath& file_path);
115 102
116 virtual bool IsDirectoryEmpty( 103 virtual bool IsDirectoryEmpty(
117 FileSystemOperationContext* context, 104 FileSystemOperationContext* context,
118 const FilePath& file_path); 105 const FilePath& file_path);
119 106
120 virtual AbstractFileEnumerator* CreateFileEnumerator( 107 virtual AbstractFileEnumerator* CreateFileEnumerator(
121 FileSystemOperationContext* context, 108 FileSystemOperationContext* context,
122 const FilePath& root_path); 109 const FilePath& root_path);
123 110
111 protected:
112 scoped_ptr<FileApiFileUtil> underlying_file_util_;
113
124 private: 114 private:
125 // Given the filesystem's root URL and a virtual path, produces a real, full 115 DISALLOW_COPY_AND_ASSIGN(OverlayFileUtil);
126 // local path.
127 FilePath GetLocalPath(
128 FileSystemOperationContext* context,
129 const GURL& origin_url,
130 FileSystemType type,
131 const FilePath& virtual_path);
132
133 scoped_ptr<FileSystemFileUtil> underlying_file_util_;
134
135 DISALLOW_COPY_AND_ASSIGN(LocalFileSystemFileUtil);
136 }; 116 };
137 117
138 } // namespace fileapi 118 } // namespace fileapi
139 119
140 #endif // WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_FILE_UTIL_H_ 120 #endif // WEBKIT_FILEAPI_OVERLAY_FILE_UTIL_H_
OLDNEW
« no previous file with comments | « webkit/fileapi/obfuscated_file_util_unittest.cc ('k') | webkit/fileapi/overlay_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698