Issue 7470027: Roll gyp 971:978

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7470027: Roll gyp 971:978 (Closed)

Created:
9 years, 5 months ago by Nico

Modified:
9 years, 5 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Roll gyp 971:978 The roll adds support for DEAD_CODE_STRIPPING to the mac make build. BUG=90078 TEST=none TBR=evan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94187

Patch Set 1 #

Patch Set 2 : git log #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 5 months ago (2011-07-26 20:25:27 UTC) #2

OK

On Tue, Jul 26, 2011 at 1:23 PM,  <thakis@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> Roll gyp 971:978
>
> The roll adds support for DEAD_CODE_STRIPPING to the mac make build.
>
> BUG=90078
> TEST=none
> TBR=evan
>
> Please review this at http://codereview.chromium.org/7470027/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
>
70b4a2dfee85eecc10b2171127477e20edf999fe..b34ed999b9af95b8c3139278d9a5db9ab7d8cb36
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -82,7 +82,7 @@ deps = {
>     (Var("googlecode_url") % "snappy") + "/trunk@37",
>
>   "src/tools/gyp":
> -    (Var("googlecode_url") % "gyp") + "/trunk@971",
> +    (Var("googlecode_url") % "gyp") + "/trunk@978",
>
>   "src/v8":
>     (Var("googlecode_url") % "v8") + "/trunk@" + Var("v8_revision"),
>
>
>

Expand Messages | Collapse Messages