Mac: fix fullscreen floating bar in popup windows.

chrome/browser/cocoa/fullscreen_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/fullscreen_controller.h"
 
 #include <algorithm>
 
 #import "chrome/browser/cocoa/browser_window_controller.h"
 #import "third_party/GTM/AppKit/GTMNSAnimation+Duration.h"
 
 
 namespace {
 // The activation zone for the main menu is 4 pixels high; if we make it any
 // smaller, then the menu can be made to appear without the bar sliding down.
 const CGFloat kDropdownActivationZoneHeight = 4;
 const NSTimeInterval kDropdownAnimationDuration = 0.12;
 const NSTimeInterval kMouseExitCheckDelay = 0.1;
 // This show delay attempts to match the delay for the main menu.
 const NSTimeInterval kDropdownShowDelay = 0.3;
 const NSTimeInterval kDropdownHideDelay = 0.2;
 
 // The amount by which the floating bar is offset downwards (to avoid the menu)
-// in fullscreen mode.
-const CGFloat kTabStripVerticalOffset = 14;
+// in fullscreen mode. (We can't use |-[NSMenu menuBarHeight]| since it returns
+// 0 when the menu bar is hidden.)
+const CGFloat kFloatingBarVerticalOffset = 22;
 
 }  // end namespace
 
 
 // Helper class to manage animations for the fullscreen dropdown bar.  Calls
 // [FullscreenController changeFloatingBarShownFraction] once per animation
 // step.
 @interface DropdownAnimation : NSAnimation {
  @private
   FullscreenController* controller_;
@@ skipping 167 matching lines @@
 }
 
 - (void)windowDidBecomeMain:(NSNotification*)notification {
   [self showActiveWindowUI];
 }
 
 - (void)windowDidResignMain:(NSNotification*)notification {
   [self hideActiveWindowUI];
 }
 
-- (CGFloat)tabStripVerticalOffset {
-  return [self isWindowOnPrimaryScreen] ? kTabStripVerticalOffset : 0;
+- (CGFloat)floatingBarVerticalOffset {
+  return [self isWindowOnPrimaryScreen] ? kFloatingBarVerticalOffset : 0;
 }
 
 - (void)overlayFrameChanged:(NSRect)frame {
   if (!isFullscreen_)
     return;
 
   // Make sure |trackingAreaBounds_| always reflects either the tracking area or
   // the desired tracking area.
   trackingAreaBounds_ = frame;
   // The tracking area should always be at least the height of activation zone.
@@ skipping 364 matching lines @@
 - (void)hideActiveWindowUI {
   if (currentFullscreenMode_ != mac_util::kFullScreenModeNormal) {
     mac_util::ReleaseFullScreen(currentFullscreenMode_);
     currentFullscreenMode_ = mac_util::kFullScreenModeNormal;
   }
 
   // TODO(rohitrao): Remove the Exit Fullscreen button.  http://crbug.com/35956
 }
 
 @end