Improve IndexedDB's quota support

content/browser/in_process_webkit/indexed_db_context.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/in_process_webkit/indexed_db_context.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/string_util.h"
@@ skipping 84 matching lines @@
 FilePath IndexedDBContext::GetIndexedDBFilePath(
     const string16& origin_id) const {
   FilePath::StringType id =
       webkit_glue::WebStringToFilePathString(origin_id).append(
           FILE_PATH_LITERAL(".indexeddb"));
   return data_path_.Append(id.append(kIndexedDBExtension));
 }
 
 void IndexedDBContext::DeleteIndexedDBFile(const FilePath& file_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
   // TODO(pastarmovj): Close all database connections that use that file.

[michaeln, 2011/07/27 01:31:35]

I see there is a close() method on WebIDBDatabase and that
IndexedDBDispatcherHost::DatabaseDispatcherHost in the browser process has a
collection of WebIDBDatabases... Would calling the close method on those
instances related to 'origin' accomplish anything useful?

[dgrogan, 2011/07/27 22:56:01]

Yes, that's how they will be closed, but more work needs to be done before we
can call it on delete.

We currently don't call it except in response to a javascript close().  There
are some non-trivial semantics dictated by the spec surrounding open, close,
delete, setVersion, and multiple connections to the backend.  It's why we
haven't yet exposed a database.delete() function.

-  file_util::Delete(file_path, false);
+  file_util::Delete(file_path, true /*recursive*/);
 }
 
 void IndexedDBContext::DeleteIndexedDBForOrigin(const string16& origin_id) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
   // TODO(pastarmovj): Remove this check once we are safe to delete any time.
   FilePath idb_file = GetIndexedDBFilePath(origin_id);
   DCHECK_EQ(idb_file.BaseName().value().substr(0, strlen("chrome-extension")),
             FILE_PATH_LITERAL("chrome-extension"));
   DeleteIndexedDBFile(GetIndexedDBFilePath(origin_id));
 }
 
+// TODO(dgrogan): Once we can delete IndexedDB directories out from underneath
+// open webkit instances, merge this and DeleteIndexedDBForOrigin.
+void IndexedDBContext::EvictOrigin(const string16& origin_id) {

[michaeln, 2011/07/27 01:31:35]

This and the method above are functionally equivalent, the only difference is
one has a DCHECK for 'chrome-extension' that the other doesn't?

[dgrogan, 2011/07/29 18:14:04]

Correct.

+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
+  FilePath idb_directory = GetIndexedDBFilePath(origin_id);
+  DeleteIndexedDBFile(idb_directory);
+}
+
 bool IndexedDBContext::IsUnlimitedStorageGranted(
     const GURL& origin) const {
   return special_storage_policy_->IsStorageUnlimited(origin);
 }
 
 // TODO(dgrogan): Merge this code with the similar loop in
 // BrowsingDataIndexedDBHelperImpl::FetchIndexedDBInfoInWebKitThread.
 void IndexedDBContext::GetAllOriginIdentifiers(
     std::vector<string16>* origin_ids) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
   file_util::FileEnumerator file_enumerator(data_path_,
       false, file_util::FileEnumerator::DIRECTORIES);
   for (FilePath file_path = file_enumerator.Next(); !file_path.empty();
        file_path = file_enumerator.Next()) {
     if (file_path.Extension() == IndexedDBContext::kIndexedDBExtension) {
       WebKit::WebString origin_id_webstring =
           webkit_glue::FilePathToWebString(file_path.BaseName());
       origin_ids->push_back(origin_id_webstring);
     }
   }
 }
 
 quota::QuotaManagerProxy* IndexedDBContext::quota_manager_proxy() {
   return quota_manager_proxy_;
 }