Issue 7469001: Enable GPU-based Gaussian blur for soft shadows. This causes some tests to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7469001: Enable GPU-based Gaussian blur for soft shadows. This causes some tests to (Closed)

Created:
9 years, 5 months ago by Stephen White

Modified:
9 years, 5 months ago

Reviewers:
reed1

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable GPU-based Gaussian blur for soft shadows. This causes some tests to time out due to Mesa slowness, some formerly-failing tests to pass, and one test failure (it's very finicky about resulting pixel values). Suppressions are added here and will be upstreamed. EDIT: I've reverted the downstream suppressions, since it turns out that the webkit_gpu_tests step doesn't look at them, either on the WebKit canaries or on the trybots (hence the red trybot runs). So I'll just land them upstream in WebKit after this CL lands. BUG=64876 TEST=layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93233

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	skia/skia.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Note that since the worst they could do is turn the bots orange, I've pre-emptively ...

9 years, 5 months ago (2011-07-20 19:13:47 UTC) #2

reed1

9 years, 5 months ago (2011-07-20 19:32:29 UTC) #3

looks redish, but the failing tests are gpu-only, and have been suppressed
upstream in webkit.

LGTM

Expand Messages | Collapse Messages